Fix issue spellid #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge original repo
removing ScriptPCH , repair build using new headers
- Adds a `LearnAllOnFirstLogin` (default: false) option to teach the player all the spells when he first logs in, - Disabled by default because of performance concerns, - Slight optimizations have been added to mitigate this issue - However enabling this on a more populous server could cause issues due to the current design of the module
- Anyone can add the missing spells directly in the code - A bit hacky, but will do the job for now.
- Before that commit, .character level 80 didn't teach any spell
- Add cosmetic mage spells to the ignore list as some are not blizzlike and some are obtained ingame, thus cutting the reward from obtaining it and not being able to show it off - Same for the warlock spell ritual of doom to summon doom guard (there is another spell anyway which is learned and is much easier to use)
feat(CI): move from Travis to GitHub Actions
Update the way the struct is called to correspond with current C++
Fix Config Errors
feat(Misc): update
fix: build and ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.