Skip to content

Optimization: avoid setting role_name for each function call #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthewhegarty wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Optimization: avoid setting role_name for each function call #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions drf_roles/mixins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,9 @@ def __init__(self, **_kwargs):
def _call_role_fn(self, fn, *args, **kwargs):
"""Attempts to call a role-scoped method"""
try:
role_name = self._get_role(self.request.user)
role_fn = "{}_for_{}".format(fn, role_name)
if not getattr(self, '_role_name', None):
Copy link

@danilodcn danilodcn Nov 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try using lru_cache from functools python module for result cache

https://docs.python.org/3/library/functools.html#functools.lru_cache

self._role_name = self._get_role(self.request.user)
role_fn = "{}_for_{}".format(fn, self._role_name)
return getattr(self, role_fn)(*args, **kwargs)
except (AttributeError, RoleError):
return getattr(super(RoleViewSetMixin, self), fn)(*args, **kwargs)
Expand Down