Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Paycall flag for reverting and add PayForGas event #195

Merged
merged 5 commits into from
Apr 29, 2024
Merged

Add Paycall flag for reverting and add PayForGas event #195

merged 5 commits into from
Apr 29, 2024

Conversation

kevincheng96
Copy link
Collaborator

@kevincheng96 kevincheng96 commented Apr 26, 2024 •
edited
Loading

This adds a constructor arg to Paycall to toggle between propagating and swallowing reverts. I also add a new PayForGas event.

@kevincheng96 kevincheng96 requested review from hayesgm and cwang25 April 26, 2024 19:24
hayesgm
hayesgm reviewed Apr 27, 2024
View reviewed changes
Copy link
Contributor

@hayesgm hayesgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just wondering if we should help track success metrics there

src/quark-core-scripts/src/Paycall.sol Show resolved Hide resolved
hayesgm
hayesgm approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@hayesgm hayesgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; thanks!

@kevincheng96 kevincheng96 merged commit 6b22766 into main Apr 29, 2024
4 checks passed
@kevincheng96 kevincheng96 deleted the kevin/revert-paycall branch April 29, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hayesgm hayesgm hayesgm approved these changes

@cwang25 cwang25 Awaiting requested review from cwang25

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevincheng96 @hayesgm