Add MultiQuarkOperation functions to QuarkWalletProxyFactory
#187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevincheng96
force-pushed
the
kevin/multi-factory
branch
from
286d0f2 to
d3bc799
Compare
hayesgm
approved these changes
Mar 22, 2024
| @@ -19,6 +19,15 @@ contract QuarkWalletProxyFactory { | |||
| /// @notice Default initial salt value | |||
| bytes32 public constant DEFAULT_SALT = bytes32(0); | |||
|
|
|||
| /// @notice The EIP-712 domain separator for a MultiQuarkOperation | |||
There was a problem hiding this comment.
I don't know why this is here?
There was a problem hiding this comment.
We decided some time ago to put the domain separator in the factory as well. IIRC, it was a gas optimization to move the public getters for domain separators from the wallet to the factory. Now that we are using proxy wallets, it doesn't really matter. But having these be on the factory is still useful in the case where the wallet does not yet exist.
kevincheng96
force-pushed
the
kevin/multi-factory
branch
from
d3bc799 to
dc365b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
createAndExecuteMultifunctions to theQuarkWalletProxyFactory.