Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename TerminalErrors to LegendErrors and move into separate file #178

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Rename TerminalErrors to LegendErrors and move into separate file #178

merged 3 commits into from
Mar 13, 2024

Conversation

kevincheng96
Copy link
Collaborator

I also made small improvements to the comments in CodeJar.

hayesgm
hayesgm approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@hayesgm hayesgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks. One comment about Dencun changes

src/codejar/src/CodeJar.sol Outdated Show resolved Hide resolved
@kevincheng96 kevincheng96 merged commit d589b56 into main Mar 13, 2024
4 checks passed
@kevincheng96 kevincheng96 deleted the kevin/moar-changes branch March 13, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hayesgm hayesgm hayesgm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevincheng96 @hayesgm