Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few ABDK audit changes #177

Merged
merged 5 commits into from
Mar 12, 2024
Merged

A few ABDK audit changes #177

merged 5 commits into from
Mar 12, 2024

Conversation

kevincheng96
Copy link
Collaborator

@kevincheng96 kevincheng96 commented Mar 12, 2024 •
edited
Loading

Two minor changes for ABDK audit:

  • Adds a small optimization to QuarkStateManager.nextNonce() to skip over buckets that are completely set
  • Adds a comment to explain the InvalidCallContext check in some Quark scripts

I also removed the unchecked blocks used for optimizing for-loops since Solidity 0.8.22 now automatically optimizes them.

fluffywaffles
fluffywaffles approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@fluffywaffles fluffywaffles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ on tests passing.

@kevincheng96
Copy link
Collaborator Author

I also removed the unchecked blocks used for optimizing for-loops since Solidity 0.8.22 now automatically optimizes them for you.

@kevincheng96 kevincheng96 merged commit 6facd00 into main Mar 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluffywaffles fluffywaffles fluffywaffles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevincheng96 @fluffywaffles