Add happy path tests for direct execution #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluffywaffles
approved these changes
Dec 14, 2023
fluffywaffles
pushed a commit
that referenced
this pull request
Dec 15, 2023
This PR adds happy path tests for direct execution of Quark wallets. `QuarkWallet.t.sol` only tested revert paths for direct execution. We do already have indirect coverage of the happy path in our tests for `Multicall`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds happy path tests for direct execution of Quark wallets.
QuarkWallet.t.solonly tested revert paths for direct execution. We do already have indirect coverage of the happy path in our tests forMulticall.