Add event for ExecuteQuarkScript

[kevincheng96]

Quark wallet now emits an event when executing a Quark script. We purposely don't emit scriptCalldata as part of the event since that can add a lot of gas. The current gas overhead is ~1.7k.

[kevincheng96]

The event actually adds a fair bit of gas overhead (~3k+). The total cost depends on the length of the scriptCalldata.

[kevincheng96]

Cut the gas overhead down from >2.5k gas to ~1.8k gas by removing the scriptCalldata field in the event.

It would be nice to keep the calldata as an event parameter, but it just adds too much overhead due to being arbitrary bytes. I considered only emitting the 4-byte function selector from the calldata, but we would need to specifically handle calldata with less than 4 byte lengths, which is possible for scripts with fallbacks.

[fluffywaffles]

overall looks good to me, will 👍 on resolution of one comment.

[fluffywaffles]

the factory test gas diffs seem large; is the branch up to date with main? 🤔

[kevincheng96]

the factory test gas diffs seem large; is the branch up to date with main? 🤔

Just rebased. Will wait to see the refreshed gas diffs.

[kevincheng96]

Gas diffs look much smaller now, around 5k extra gas per deploy of the wallet.

[cwang25]

LGTM.

I as as long as the gas is not increased to much I always in favor of having more logs hehe.