Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc changes in Info section of CS Audit 7.x #124

Merged
merged 23 commits into from
Dec 15, 2023
Merged

Misc changes in Info section of CS Audit 7.x #124

merged 23 commits into from
Dec 15, 2023

Conversation

cwang25
Copy link
Contributor

@cwang25 cwang25 commented Dec 8, 2023 •
edited
Loading

  • 7.2.2
  • 7.2.3
  • 7.2.4 Removed now. Since caching domainSeparator actually cost more gas than not.
  • 7.2.5
  • 7.2.7
  • 7.2.10
  • 7.2.11
  • 7.3
  • 7.6
  • 7.7

kevincheng96
kevincheng96 reviewed Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@kevincheng96 kevincheng96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. The PR description is missing 7.2.7

@cwang25 cwang25 force-pushed the hans/cs-audit-misc-7.x branch 2 times, most recently from d4f413d to 00f3f33 Compare December 13, 2023 00:10
@cwang25 cwang25 force-pushed the hans/cs-audit-misc-7.x branch from 22deca5 to c2a897c Compare December 13, 2023 19:04
fluffywaffles
fluffywaffles approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@fluffywaffles fluffywaffles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing blocking. looks ready to merge

kevincheng96
kevincheng96 reviewed Dec 14, 2023
View reviewed changes
@cwang25 cwang25 requested a review from kevincheng96 December 14, 2023 21:28
Hans Wang added 19 commits December 14, 2023 14:33
address 7.7
b282891
address 7.3
e290ca4
address 7.2.5
cb2d8bd
address 7.2.2
82f311a
address 7.2.3
c8a3d9e
fix poolkey import syntax
f540c3e
address 7.2.7
1ab4872
address 7.6 unused code
9206f09
address comments
d4241da
added leftover pk variable name
301fcf6
address 7.2.10
dca38d6
address 7.2.4
0cd9991
address 7.2.11
ddced9d
fix test errors as the domain separtor need to save into the proxy as…
ffb49a3 
… well and retrieve via special getter
Revert "fix test errors as the domain separtor need to save into the …
126db07 
…proxy as well and retrieve via special getter"

This reverts commit 00f3f33.
Revert "address 7.2.4"
61c5c6e 
This reverts commit bf7f87a.
add test for approval refund
97270c5
just put it below, and don't use else
3c64772
Revert "address 7.2.7"
2d61471 
This reverts commit 37435c9.
@cwang25 cwang25 force-pushed the hans/cs-audit-misc-7.x branch from 448c423 to f70d8e0 Compare December 14, 2023 22:37
kevincheng96
kevincheng96 approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@kevincheng96 kevincheng96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one more comment. Otherwise looks great

@cwang25 cwang25 merged commit a0195ca into main Dec 15, 2023
4 checks passed
@cwang25 cwang25 deleted the hans/cs-audit-misc-7.x branch December 15, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluffywaffles fluffywaffles fluffywaffles approved these changes

@kevincheng96 kevincheng96 kevincheng96 approved these changes

@hayesgm hayesgm Awaiting requested review from hayesgm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cwang25 @fluffywaffles @kevincheng96