Address L2/Q4 #112
Merged
Address L2/Q4 #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cwang25
commented
Dec 5, 2023
cwang25
commented
- invalidate uint96.max nonce value
- optimize nextNonce() by shifting bits instead of layers of function calls
- optimized nextNonce() by providing offset to the function as suggested
added 2 commits
December 4, 2023 18:00
… are getting nextNonce() directly from stateManager in our scenarios instead of passing through factory
cwang25
requested review from
kevincheng96 and
fluffywaffles
and removed request for
kevincheng96
kevincheng96
reviewed
Dec 5, 2023
kevincheng96
approved these changes
Dec 6, 2023
Co-authored-by: Kevin Cheng <[email protected]>
kevincheng96
reviewed
Dec 7, 2023
kevincheng96
reviewed
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.