Added test for Fetcher fetchRoute + other stuff :) #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p1pchenk0
commented
May 25, 2023
p1pchenk0
commented
- test for fetcher
- failing unit tests after updates
* failing unit tests after updates
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## nuxt3 nuxt/nuxt-vitest#103 +/- ##
==========================================
+ Coverage 95.48% 95.82% +0.33%
==========================================
Files 54 55 +1
Lines 3898 3926 +28
Branches 590 604 +14
==========================================
+ Hits 3722 3762 +40
+ Misses 176 164 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Fab, thanks, good to merge or do you want to keep working on this branch tomorrow? |
yes, I think it would be the best option to continue working here |
* moved boolean check from ComponentGroup template to computed
p1pchenk0
changed the title
…g and mocking * unskip tests for route middleware
| }) | ||
| }) | ||
|
|
||
| test.todo('should return correct values for client/server flags IF env is server-side', () => { |
There was a problem hiding this comment.
Thank you, please add a comment Disabled due to nuxt-vitest bug - track issue and progress here https://github.com/danielroe/nuxt-vitest/issues/162
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.