fix(BCH-1147): emit started evidence synchronously at trigger time#397
Open
saltpy-cs wants to merge 2 commits into
Open
fix(BCH-1147): emit started evidence synchronously at trigger time#397saltpy-cs wants to merge 2 commits into
saltpy-cs wants to merge 2 commits into
Conversation
…r time Add an optional evidence creator to the Manager so that "started" evidence is emitted immediately when StartWorkflowExecution is called, closing the timing gap that existed between execution creation (status=pending, startedAt populated) and the async in_progress transition where evidence was previously wired. Add tests capturing the bug and the nil-creator safety path. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…completed evidence SetEvidenceCreator was never called on the workflow manager, so started evidence was never emitted at trigger time. Also removes the duplicate completed evidence emission from UpdateStatus — completion evidence is already written via AddExecutionCompletionEvidence in the executor, which uses correct timestamps and richer metadata. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional evidence creator to the Manager so that "started" evidence is emitted immediately when StartWorkflowExecution is called, closing the timing gap that existed between execution creation (status=pending, startedAt populated) and the async in_progress transition where evidence was previously wired. Add tests capturing the bug and the nil-creator safety path.