-
Notifications
You must be signed in to change notification settings - Fork 35
Fix incorrect build instructions #734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix incorrect build instructions #734
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #734 +/- ##
=======================================
Coverage 79.83% 79.83%
=======================================
Files 9 9
Lines 3963 3963
=======================================
Hits 3164 3164
Misses 799 799 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These flags are unecessary as well..
Cling_DIR for sure, iirc we are no longer required to pass Clang_DIR. But thats based on how I build locally so there could be cases where it is required that I don't know of
| mkdir CppInterOp/build/ | ||
| cd CppInterOp/build/ | ||
| cmake -DBUILD_SHARED_LIBS=ON -DCPPINTEROP_USE_CLING=ON -DCPPINTEROP_USE_REPL=Off -DCling_DIR=$LLVM_DIR/build/tools/cling -DLLVM_DIR=$LLVM_DIR/build/lib/cmake/llvm -DClang_DIR=$LLVM_DIR/build/lib/cmake/clang -DCMAKE_INSTALL_PREFIX=$CPPINTEROP_DIR .. | ||
| cmake -DBUILD_SHARED_LIBS=ON -DCling_DIR=$LLVM_DIR/build/tools/cling -DLLVM_DIR=$LLVM_DIR/build/lib/cmake/llvm -DClang_DIR=$LLVM_DIR/build/lib/cmake/clang -DCMAKE_INSTALL_PREFIX=$CPPINTEROP_DIR .. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| cmake -DBUILD_SHARED_LIBS=ON -DCling_DIR=$LLVM_DIR/build/tools/cling -DLLVM_DIR=$LLVM_DIR/build/lib/cmake/llvm -DClang_DIR=$LLVM_DIR/build/lib/cmake/clang -DCMAKE_INSTALL_PREFIX=$CPPINTEROP_DIR .. | |
| cmake -DBUILD_SHARED_LIBS=ON -DLLVM_DIR=$LLVM_DIR/build/lib/cmake/llvm -DCMAKE_INSTALL_PREFIX=$CPPINTEROP_DIR .. |
|
@aaronj0 Thanks for the review. Good catch with the leftover Cling dir reference. Somehow I completely forgot about that. I think your right about clang_dir not being necessary. I think the cmake logic is such that as long as you pass either llvm_dir or clang_dir then it should be able to find the other. I will check this is true, and if yes, purge any reference to clang_dir from the documentation and ci so everything is consistent. |
Description
Please include a summary of changes, motivation and context for this PR.
-DCPPINTEROP_USE_CLING=ON -DCPPINTEROP_USE_REPL=Offtells CppInterOp to use Cling in the clang-repl based instructions. Found this while working on the llvm 21 PR.Fixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist