Out-Of-Process Interpreter for CppInterOp #717
Conversation
Vipul-Cariappa
force-pushed
the
cppinterop-out
branch
from
c56d565 to
7217df9
Compare
|
Before pushing commits to this PR please either ping me, or delete caches as they are made. This PR has caused a large number of llvm cached builds to be deleted on main, which in turn has required multiple PRs workflow runs to be stopped while the cache is rebuilt. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #717 +/- ##
==========================================
- Coverage 79.83% 79.56% -0.28%
==========================================
Files 9 9
Lines 3963 4057 +94
==========================================
+ Hits 3164 3228 +64
- Misses 799 829 +30
🚀 New features to boost your workflow:
|
The tests are not covering over 1/4 of this patch. @kr-2003 can you improve the coverage? |
|
|
||
| if (NOT EMSCRIPTEN) | ||
| set(EXTRA_TEST_SOURCE_FILES "") | ||
| set(EXTRA_TEST_SOURCE_FILES Utils.cpp) |
There was a problem hiding this comment.
Why we add this line on top and the same here?
There was a problem hiding this comment.
The reason it was reset to nothing previously was to stop the cuda tests being run twice. Given Utils.cpp is needed unconditionally then its not needed in EXTRA_TEST_SOURCE_FILES . Utils.cpp should just be included in both lists of test files, and anything which changed EXTRA_TEST_SOURCE_FILES should be reverted.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| bool use_oop_jit; | ||
|
|
||
| TestConfig(bool oop_jit, const std::string& n) | ||
| : name(std::move(n)), use_oop_jit(oop_jit) {} |
There was a problem hiding this comment.
warning: std::move of the const variable 'n' has no effect; remove std::move() or make the variable non-const [performance-move-const-arg]
| : name(std::move(n)), use_oop_jit(oop_jit) {} | |
| : name(n), use_oop_jit(oop_jit) {} |
4 participants
This PR enables Out-Of-Process Interpreter for CppInterOp.
Under the hood, it uses LLVM's
llvm-jitlink-executorandlib ORC RTto delegate the JIT execution to different process. The user just needs to pass--use-oop-jitflag as ClangArgs while constructing the interpreter to use this feature.