-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add seastar 2211 version to infra #1134
Add seastar 2211 version to infra #1134
Conversation
The existing seastar version 1808 is more than five years old and lots of exciting changes have occurred since then. This patch adds seastar 2211 from last last year so that it can be be exposed by CE.
The existing seastar version 1808 is more than five years old and lots of exciting changes have occurred since then. This patch adds seastar 2211 from last last year as well as trunk. The 2211 version of seastar requires PR compiler-explorer/infra#1134 to be accepted first to add it on the infra side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Travis!
There's no trunk install, but I'll hack that now. |
Oh...there is...sorry! 😊 |
The existing seastar version 1808 is more than five years old and lots of exciting changes have occurred since then. This patch adds seastar 2211 from last last year as well as trunk. The 2211 version of seastar requires PR compiler-explorer/infra#1134 to be accepted first to add it on the infra side. `make check` passes.
Thanks so much for merging this @mattgodbolt - we are having a lot of fun with it already! A couple of questions came up while we making this PR, I guess either you or @partouf would know:
|
Dependencies are mostly for linking yes, dependencies are hard because you would have to pre-define the version of the library, where we'd like to keep some flexibility. There are however some libraries that add the include paths of specific versions to their own, so it's automatic, but also hardcoded. (example https://github.com/compiler-explorer/compiler-explorer/blob/4a8fdbf81005517e9b77242856d2651d20438145/etc/config/c%2B%2B.amazon.properties#L3822) What we usually do is just add something to the description of the library (example https://github.com/compiler-explorer/compiler-explorer/blob/main/etc/config/c%2B%2B.amazon.properties#L3186) Regarding the define: QT needed that too, we solved it with this https://github.com/compiler-explorer/compiler-explorer/blob/4a8fdbf81005517e9b77242856d2651d20438145/etc/config/c%2B%2B.amazon.properties#L3979 - note that you will not be able to override this define. |
Thank you for adding the new seastar version to CE. Happy to see it. My setup is clang 16.0, args are: |
@Genomorf here's a working link: https://gcc.godbolt.org/z/WjG3aoY64 Keys are: Define |
@travisdowns thank you for the answer, but your example has the same linker error. If you open the "output" tab you can see I use CE as a sandbox platform to run the code, print messages, experiment with the tasks. I can't do it with your example. It only compiles. Is there an option to actually run the code? |
We do not build binaries for seastar, so linking will not work. We can look into it |
@partouf is it hard for CE to build binaries for seastar? I can help and try to solve the issue if there is a guide or example, or at least some directions how to do it. |
The existing seastar version 1808 is more than five years old and lots of exciting changes have occurred since then. This patch adds seastar 2211 from last last year so that it can be be exposed by CE.