Skip to content

Fixed the previous fix of the anti-nag hook and propagated fixes everywhere #6162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025

Conversation

imcrazytwkr
Copy link
Contributor

@imcrazytwkr imcrazytwkr commented Jul 22, 2025

✍️ Description

The old fix of the anti-nag apt hook had some unintended side effects as reported today by @memesalot and @vsc55 in #6078. This PR fixes this. What is being done in particular:

🔗 Related PR / Issue

Link: #6078
Link: #6084
Link: #6095
Link: #6098
Link: #6158

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected. Tested myself on 8.0.0, 8.0.3, 8.4.1 and 8.4.5. This time also tested by @vsc55 (message link) and @memesalot (message link)
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

@imcrazytwkr imcrazytwkr requested a review from a team as a code owner July 22, 2025 16:23
@github-actions github-actions bot added pve-tool update script A change that updates a script labels Jul 22, 2025
@imcrazytwkr
Copy link
Contributor Author

imcrazytwkr commented Jul 22, 2025

Hi @vsc55! Can I bother you to test this one on 8.0 too just in case? I've tested it myself but the more eyes on the code, the better.

@vsc55
Copy link

vsc55 commented Jul 22, 2025

Hi @vsc55! Can I bother you to test this one on 8.0 too just in case? I've tested it myself but the more eyes on the code, the better.

Hi @imcrazytwkr, I've tried it and it works perfectly. 👌

@tremor021 tremor021 merged commit 0f3b95b into community-scripts:main Jul 22, 2025
3 checks passed
@imcrazytwkr imcrazytwkr deleted the fix-no-nag branch July 22, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature pve-tool update script A change that updates a script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proxmox Backup Server Post Install no-nag-script on 3.4.3 does not disable subscription nag
4 participants