initial PR for librenms #1704
Open
initial PR for librenms #1704
+242
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
new script
github-actions
bot
added
maintenance
|
Remove Change on build.func please |
Yes sorry, I added it cause I figured out how to "fix" timezone warning. |
michelroegl-brunner
requested changes
Jan 26, 2025
ct/librenms.sh
Outdated
| msg_error "No ${APP} Installation Found!" | ||
| exit | ||
| fi | ||
| msg_ok "${APP} automatically updated!" |
There was a problem hiding this comment.
The app updates on its own without user input?
|
|
||
| # Copyright (c) 2021-2025 community-scripts ORG | ||
| # Author: SvennD | ||
| # License: MIT |
There was a problem hiding this comment.
License in one line
install/librenms-install.sh
Outdated
| $STD useradd librenms -d /opt/librenms -M -r | ||
|
|
||
| # set timezone | ||
| $STD timedatectl set-timezone Etc/UTC |
install/librenms-install.sh
Outdated
|
|
||
| msg_info "download librenms" | ||
| cd /opt | ||
| $STD git clone https://github.com/librenms/librenms.git --depth 1 |
There was a problem hiding this comment.
No git clone if possible. Download latest release. have a look at the guides in the wiki.
install/librenms-install.sh
Outdated
Comment on lines
65
to
66
| $STD systemctl enable librenms-scheduler.timer | ||
| $STD systemctl start librenms-scheduler.timer |
There was a problem hiding this comment.
Suggested change
| $STD systemctl enable librenms-scheduler.timer | |
| $STD systemctl start librenms-scheduler.timer | |
| systemctl enable -q —now librenms-scheduler.timer |
Co-authored-by: Michel Roegl-Brunner <[email protected]>
Co-authored-by: Michel Roegl-Brunner <[email protected]>
|
Thanks for the review @michelroegl-brunner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Description
Librenms is a fully featured network monitoring system that provides a wealth of features and device support.
✅ Prerequisites
The following steps must be completed for the pull request to be considered:
🛠️ Type of Change
Please check the relevant options:
📋 Additional Information (optional)
Given this is my first script, I would appreciate any (contructive) feedback ! I created it, cause I would like to use it myself. But of course the entire community can use it :) I expect to still improve some small things.
After the web installation, you get to this screen : the 2 warnings, ofcourse can be resolved by adding devices to monitor and set the specific url (domain) or ip. (minor things)
