Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Script: zoneminder #1662

Conversation

connorjfarrell
Copy link

✍️ Description

Create ZoneMinder CT script

creates ubuntu 22.04 CT w/ mariadb+zoneminder (installed via apt ref. PPA repo). Based on: https://zoneminder.readthedocs.io/en/stable/installationguide/ubuntu.html#ubuntu-22-04-jammy



✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)

🛠️ Type of Change

Please check the relevant options:

  • [] Bug fix (non-breaking change that resolves an issue)
  • [] New feature (non-breaking change that adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

📋 Additional Information (optional)

Provide any extra context or screenshots about the feature or fix here.

@github-actions github-actions bot added new script A change that adds a new script website A change to the website labels Jan 22, 2025
@connorjfarrell connorjfarrell marked this pull request as ready for review January 22, 2025 04:58
@connorjfarrell connorjfarrell requested a review from a team as a code owner January 22, 2025 04:58
@michelroegl-brunner
Copy link
Member

Why an old ubuntu? debian 12 is supported wich is our default.

@MickLesk
Copy link
Member

And why so many Missing informations, and old Comments from Dev Guide?

@michelroegl-brunner michelroegl-brunner changed the title Connorjfarrell/zoneminder New Script: zoneminder Jan 22, 2025
@connorjfarrell
Copy link
Author

@michelroegl-brunner

Why an old ubuntu? debian 12 is supported wich is our default.

Ubuntu vs Debian - debian install/update process less straightforward to stay up to date w/ latest ZM releases.
Old version - misread ZM docs when I started creating, can try w/ 24.04 and validate still builds.

@MickLesk

And why so many Missing informations, and old Comments from Dev Guide?

What information am I missing (other than the header metadata which should now be updated)? By old comments, are you referencing the comments on lines 8-24 of zoneminder.sh?

@michelroegl-brunner
Copy link
Member

He means all the comments you have in there remove them.

Also please shorten all messages in msg_info and msg_ok. max 4 words per. Also during update, remove some of the messges, they are to much.
also remove the backup you created during update. backups have to be done by the user.

@connorjfarrell
Copy link
Author

Removed comments, shorted msg_info+msg_ok messages, removed messages during update, removed backup from update function

@michelroegl-brunner
Copy link
Member

Can you give it a try with debain 12 or at least ubuntu 24.04? Otherwise we have to update it latest next year anyway.

@tremor021
Copy link
Member

Can you give it a try with debain 12 or at least ubuntu 24.04? Otherwise we have to update it latest next year anyway.

also, the install script for debian is super simple:

!/bin/sh
clear
read -p "This script installs ZoneMinder 1.36.x on Debian 12 with LAMP (MySQL or Mariadb) installed...
This script must be run as root!
Press Enter to continue or Ctrl + c to quit" nothing
clear
apt install -y lsb-release gnupg2
echo "deb https://zmrepo.zoneminder.com/debian/release-1.36 "`lsb_release  -c -s`"/" | sudo tee /etc/apt/sources.list.d/zoneminder.list
wget -O - https://zmrepo.zoneminder.com/debian/archive-keyring.gpg | sudo apt-key add -
read -p "Warning! Check above to insure the line says OK. If not the GPG signing key was not installed and you will need to figure out why before continuing. 
Press enter to continue" nothing
apt update
clear
apt install zoneminder --install-recommends -y
systemctl enable zoneminder
service zoneminder start
adduser www-data video
a2enconf zoneminder
a2enmod rewrite
a2enmod headers
a2enmod expires
service apache2 reload
clear
read -p "Install complete. Open Zoneminder/Options and set the timezone. Press enter to continue" nothing
clear

@MickLesk
Copy link
Member

Can you give it a try with debain 12 or at least ubuntu 24.04? Otherwise we have to update it latest next year anyway.

also, the install script for debian is super simple:

!/bin/sh
clear
read -p "This script installs ZoneMinder 1.36.x on Debian 12 with LAMP (MySQL or Mariadb) installed...
This script must be run as root!
Press Enter to continue or Ctrl + c to quit" nothing
clear
apt install -y lsb-release gnupg2
echo "deb https://zmrepo.zoneminder.com/debian/release-1.36 "`lsb_release  -c -s`"/" | sudo tee /etc/apt/sources.list.d/zoneminder.list
wget -O - https://zmrepo.zoneminder.com/debian/archive-keyring.gpg | sudo apt-key add -
read -p "Warning! Check above to insure the line says OK. If not the GPG signing key was not installed and you will need to figure out why before continuing. 
Press enter to continue" nothing
apt update
clear
apt install zoneminder --install-recommends -y
systemctl enable zoneminder
service zoneminder start
adduser www-data video
a2enconf zoneminder
a2enmod rewrite
a2enmod headers
a2enmod expires
service apache2 reload
clear
read -p "Install complete. Open Zoneminder/Options and set the timezone. Press enter to continue" nothing
clear

Looks much better

@michelroegl-brunner
Copy link
Member

@connorjfarrell You are still on the changes to debian 12?

@MickLesk MickLesk marked this pull request as draft February 5, 2025 12:30
@MickLesk
Copy link
Member

No further user response received at PR.

@MickLesk MickLesk closed this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new script A change that adds a new script website A change to the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants