-
-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New script: Local Certificate Authority based upon Smallstep's step-ca #1655
base: main
Are you sure you want to change the base?
Conversation
- Disable policy update due to issues - Small updates
- Wait for service to be completed - Cleanup old code - Added documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script breaks a few standards. First, why have you divided the installation in two parts?
Then remove the comments.
and you can remove the part with motd file. This is no longer used this way.
- replace motd with .profile
@michelroegl-brunner Thanks for the feedback.
Assuming you refer to alpine-step-ca-install.sh, during troubleshooting I found it more stable /easier to complete the steps of the OS first (incl customizations) and amend with the installation and configuration of step-ca. in case the configuration fails, at least the OS is accessible.
Done
I switched to .profile avoiding motd, while the user can still quickly access the fingerprint to onboard new clients to the ACME service. |
Please have a look at our Guides. Please move all install parts int the *-install.sh file. Also, are all these inputs really necessary? Cant you use some sort of default values wich can get changed later in a config file. Maybe write a short guide for this? Also you are doing many things not the way our standard is, have a look at the guides. |
Any progress? |
Apologies having troubles to understand the install parts outside of the -install.sh you refer to. As far as I'm aware I separated the dialog for input with the customer to be in the ct/.sh and the actual install and configuration in the install/-install.sh. The only 'install'/update element in the ct/.sh is related to the update_script() which follows the example of the contribution guide. I will have another check on the contribution guide. So far I guess my environment variable handling and usage of $STD could be improved. However the main question for me would be around your feedback whether the inputs are really necessary. Typically with a certificate authority you don't want to regenerate your root certificate for obvious reasons. Hence this step of the configuration process should be done only once. I included the input dialog to have an one-off flow with the user to deliver a turnkey ready-to-go local certificate authority. Moving the dialog/configuration steps into separate scripts blocks the ability to start the service at the end of the script as it needs to be initialize first. Using defaults forces the user to regenerate the root certificate (or at least for the naming of the CA part). Looking forward to your thoughts whether it makes sense to pursue a (integrated) ProxmoxVE script? or would be better to split allowing the user to use the existing AlpineOS script use, and install/configurre the CA with another script? (should we close this PR and continue the chat elsewhere?) |
✍️ Description
New script to create an Alpine-based container running a local Certificate Authority based upon Smallstep's OS "step-ca" (url: https://smallstep.com/docs/step-ca/).
This release provides - next to the default config GUI - a GUI to configure:
✅ Prerequisites
The following steps must be completed for the pull request to be considered:
🛠️ Type of Change
Please check the relevant options:
📋 Additional Information (optional)
Provide any extra context or screenshots about the feature or fix here.