Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Script: Synology VM #1622

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

New Script: Synology VM #1622

wants to merge 19 commits into from
+454 −0

Conversation

tim104979
Copy link

✍️ Description

Tested on my own proxmox EV worked great!

  • Related Issue: #
  • Related PR: #
  • Related Discussion: #

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)

🛠️ Type of Change

Please check the relevant options:

  • [] Bug fix (non-breaking change that resolves an issue)
  • [] New feature (non-breaking change that adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

📋 Additional Information (optional)

Provide any extra context or screenshots about the feature or fix here.

@tim104979 tim104979 requested a review from a team as a code owner January 20, 2025 20:34
@github-actions github-actions bot added new script A change that adds a new script website A change to the website labels Jan 20, 2025
@michelroegl-brunner
Copy link
Member

Files double/in wrong place.

@tim104979
Copy link
Author

This is fixed it is now only the necessary files

@MickLesk
Copy link
Member

  1. lowercase all files, workflow action blocked
  2. vm files without -install.sh, look @ debian-vm.sh
  3. ascii art is "slant" for header
  4. category in the json is wrong (0 = misc). https://community-scripts.github.io/ProxmoxVE/json-editor

@tim104979
Copy link
Author

Made the requested changes

michelroegl-brunner
michelroegl-brunner requested changes Jan 21, 2025
View reviewed changes
json/synology-vm.json Outdated Show resolved Hide resolved
vm/synology-vm.sh Outdated Show resolved Hide resolved
@tim104979
Copy link
Author

made the changes

michelroegl-brunner
michelroegl-brunner reviewed Jan 21, 2025
View reviewed changes
Copy link
Member

@michelroegl-brunner michelroegl-brunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok, but needs testing after merge. @MickLesk can you have a look at it befor merging? im not so familiar with the vm scripts.

bragra
bragra reviewed Jan 23, 2025
View reviewed changes
vm/synology-vm.sh Outdated Show resolved Hide resolved
@tim104979
Copy link
Author

This is fixed

@tim104979
Copy link
Author

the date was wrong in the json so i fixed that

@MickLesk
Copy link
Member

Doesnt work.

image

@tim104979
Copy link
Author

Okay i will look into what changed

@tim104979
Copy link
Author

this is now fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bragra bragra bragra left review comments

@michelroegl-brunner michelroegl-brunner michelroegl-brunner left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
new script A change that adds a new script website A change to the website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tim104979 @michelroegl-brunner @MickLesk @bragra