Skip to content

2022 Week 41 release #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 67 commits into from
Oct 17, 2022
Merged

2022 Week 41 release #281

merged 67 commits into from
Oct 17, 2022

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented Oct 12, 2022

For review & deploy Friday, October 14th ish.

This PR will update automatically as additional contributions are merged into the main branch.

Outstanding issues:

Fienne and others added 30 commits October 9, 2022 22:20
* Show cwltool --make-template to users in the chapter where we introduce the inputs objects
* Add a troubleshooting section for the cachedir docs

Co-authored-by: Michael R. Crusoe <[email protected]>
* Link to #$include in the note
* 'Important' box wasn't terminated properly

Co-authored-by: Michael R. Crusoe <[email protected]>
…mmand output lines (#247)

* Highlight lines of interest in the command outputs
* Rename "Advanced Inputs" to "Inclusive and Exclusive Inputs"
* Add text about the exclusive input parameters and expressions
* explain why itemC was chosen when both are provided

Co-authored-by: Michael R. Crusoe <[email protected]>
"pip install -e .[all]" doesn't work if you don't have setup.py.
We're using a declarative package config so we need to invoke it
slightly differently.
update note content and add windows OS and link to install cwltool
remigathoni and others added 7 commits October 13, 2022 08:32
Co-authored-by: Michael R. Crusoe <[email protected]>
Co-authored-by: “gathoni-k” <“[email protected]”>
* modified sentence

* modified quick-start.md
* Increase navigation depth to 3

* Expand left sidebar

* Revert "Expand left sidebar"

This reverts commit a3dc19b.

Co-authored-by: “gathoni-k” <“[email protected]”>
Co-authored-by: “gathoni-k” <“[email protected]”>
Co-authored-by: SWZ <[email protected]>
* Update README with current render

* update README with released and RTD user guide
@common-workflow-language common-workflow-language deleted a comment from mr-c Oct 14, 2022
@swzCuroverse
Copy link
Contributor

The json file has a different DOI than the readme -- do we want the json to point to the latest release but the readme to point to the general zenodo which houses all the releases, or should they match. Additionally, who is in charge of putting the zenodo entry to match the zenodo.json file in the GitHub repository? I know there exist github actions for zenodo but don't know if he have them set up or not. @kinow perhaps you know?

@mr-c
Copy link
Member Author

mr-c commented Oct 16, 2022

The json file has a different DOI than the readme

The Zenodo JSON file points to multiple related DOIs.

"notes": "Based off of the excellent Software/Data Carpentry templates: https://doi.org/10.5281/zenodo.838778",

is a reference to the template we used to use from the Carpentries, and thus can be removed.

"identifier": "10.5281/zenodo.840129",

Is a reference to the "all versions of this resource" parent DOI for the User Guide, as detailed at https://help.zenodo.org/#versioning

The badge will show the DOI for the latest release of the user.

-- do we want the json to point to the latest release but the readme to point to the general zenodo which houses all the releases, or should they match. Additionally, who is in charge of putting the zenodo entry to match the zenodo.json file in the GitHub repository? I know there exist github actions for zenodo but don't know if he have them set up or not. @kinow perhaps you know?

So there is no reason to update the Zenodo JSON file. Each new GitHub release automatically uploads to Zenodo.

P.S. You deleted a comment I made in response to your earlier inquiry (and that inquiry itself). Continued deletion of my comments will undermine your retaining write privileges in this and any other CWL repository.

README.md Outdated
Comment on lines 5 to 6
[Released User guide for CWL v1.2.0](https://www.commonwl.org/user_guide/) : This is the released version which corresponds to the release branch.
[Read The Docs User guide for CWL v1.2.0](https://common-workflow-languageuser-guide.readthedocs.io/en/latest/) : This is the Read The Docs(RTD) version which corresponds to the main branch.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use plain URL links here, please. The link text is too similar to each other.

RTD is defined here and never used again, so remove that abbreviation.

Copy link
Contributor

@swzCuroverse swzCuroverse Oct 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it was added because we in tickets and other places (like chat) use RTD so people were wondering what that meant. So, I think even though not used in the README again, it might be nice to somehow tell me what common acronyms people are using. Not sure if this is the place to do this - but just an FYI.

@swzCuroverse
Copy link
Contributor

The json file has a different DOI than the readme

The Zenodo JSON file points to multiple related DOIs.

"notes": "Based off of the excellent Software/Data Carpentry templates: https://doi.org/10.5281/zenodo.838778",

is a reference to the template we used to use from the Carpentries, and thus can be removed.

"identifier": "10.5281/zenodo.840129",

Is a reference to the "all versions of this resource" parent DOI for the User Guide, as detailed at https://help.zenodo.org/#versioning

The badge will show the DOI for the latest release of the user.

-- do we want the json to point to the latest release but the readme to point to the general zenodo which houses all the releases, or should they match. Additionally, who is in charge of putting the zenodo entry to match the zenodo.json file in the GitHub repository? I know there exist github actions for zenodo but don't know if he have them set up or not. @kinow perhaps you know?

So there is no reason to update the Zenodo JSON file. Each new GitHub release automatically uploads to Zenodo.

I assume you mean the Zenodo entry since you have a ticket to update the .json file. Documentation of this and the release process would be welcome. Also, it seems like the release is a moving target. So it would be nice to know if we now have a complete list for the release.

@swzCuroverse swzCuroverse reopened this Oct 17, 2022
@mr-c
Copy link
Member Author

mr-c commented Oct 17, 2022

@bamiwoaluko , @Gathoni-K, and @Mackenzie-OO7: Under which name shall we list you in the AUTHORS.md ?

@swzCuroverse
Copy link
Contributor

swzCuroverse commented Oct 17, 2022

@bamiwoaluko , @Gathoni-K, and @Mackenzie-OO7: Under which name shall we list you in the AUTHORS.md ?

I don't think we should require people to give their formal names to be listed as authors. I think it is fine if they do - but it shouldn't be an obligation. People may for several reasons not be using their legal names and/or not want their names (legal or not) to be made available on a project.

@mr-c
Copy link
Member Author

mr-c commented Oct 17, 2022

@bamiwoaluko , @Gathoni-K, and @Mackenzie-OO7: Under which name shall we list you in the AUTHORS.md ?

I don't think we should require people to give their formal names to be listed as authors. I think it is fine if they do - but it shouldn't be an obligation. People may for several reasons not be using their legal names and/or not want their names (legal or not) to be made available on a project.

Agreed, I already listed them by their GitHub handles as shown in c757074 ; just giving them a chance to choose how they will be represented.

@swzCuroverse
Copy link
Contributor

@bamiwoaluko , @Gathoni-K, and @Mackenzie-OO7: Under which name shall we list you in the AUTHORS.md ?

I don't think we should require people to give their formal names to be listed as authors. I think it is fine if they do - but it shouldn't be an obligation. People may for several reasons not be using their legal names and/or not want their names (legal or not) to be made available on a project.

Agreed, I already listed them by their GitHub handles as shown in c757074 ; just giving them a chance to choose how they will be represented.

Makes sense to me.

@mr-c mr-c merged commit 61e8478 into release Oct 17, 2022
@remigathoni
Copy link
Contributor

@bamiwoaluko , @Gathoni-K, and @Mackenzie-OO7: Under which name shall we list you in the AUTHORS.md ?

Mary Gathoni

@bamiwoaluko
Copy link
Contributor

@bamiwoaluko , @Gathoni-K, and @Mackenzie-OO7: Under which name shall we list you in the AUTHORS.md ?

Bamiwo Aluko

@Mackenzie-OO7
Copy link
Contributor

@bamiwoaluko , @Gathoni-K, and @Mackenzie-OO7: Under which name shall we list you in the AUTHORS.md ?

Levai Mackenzie Agbara

@mr-c
Copy link
Member Author

mr-c commented Oct 19, 2022

Levai Mackenzie Agbara

@Mackenzie-OO7 To confirm, should it be Agbara or Ágbàrà ?

* Levai Mackenzie Ágbàrà (@Mackenzie-OO7)

@Mackenzie-OO7
Copy link
Contributor

Mackenzie-OO7 commented Oct 19, 2022

Levai Mackenzie Agbara

@Mackenzie-OO7 To confirm, should it be Agbara or Ágbàrà ?

* Levai Mackenzie Ágbàrà (@Mackenzie-OO7)

It should be Ágbàrà, I couldn't get those letters on my device earlier, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants