Skip to content

Conversation

@yousefsaad12
Copy link
Contributor

@yousefsaad12 yousefsaad12 commented Oct 14, 2025

Description

This pull request adds a utility to format large numerical values using compact notation (for example, 1,200,000,000 → 1.2B) to improve readability in the Crypto dashboard.

Fixes #39

Changes

  • Added formatCompactNumber() utility using Intl.NumberFormat with notation: "compact"
  • Updated components (Card.jsx, Crypto.jsx) to display formatted numbers
  • Added fallback handling for smaller values

Example

Before After
1200000 1.2M
5400000000 5.4B

Screenshot

Uploading image.png…

@vercel
Copy link

vercel bot commented Oct 14, 2025

@yousefsaad12 is attempting to deploy a commit to the venisha-kalola's projects Team on Vercel.

A member of the Team first needs to authorize it.

@venisha-kalola
Copy link
Contributor

add the issue number # , the original issue number which was assigned to you

@yousefsaad12 yousefsaad12 changed the title feat: format large numbers with compact display (1.2B, 900M, etc) feat: format large numbers with compact display (1.2B, 900M, etc) Fixes #123 Oct 15, 2025
@yousefsaad12 yousefsaad12 changed the title feat: format large numbers with compact display (1.2B, 900M, etc) Fixes #123 feat: format large numbers with compact display (1.2B, 900M, etc) Fixes #39 Oct 15, 2025
@yousefsaad12 yousefsaad12 changed the title feat: format large numbers with compact display (1.2B, 900M, etc) Fixes #39 feat(#39): format large numbers with compact display (1.2B, 900M, etc.) Oct 15, 2025
@yousefsaad12
Copy link
Contributor Author

add the issue number # , the original issue number which was assigned to you

done

@venisha-kalola
Copy link
Contributor

check the latest weather.jsx, u currently have merge conflicts with the file, can u update the code and re-submit a PR without any conflicts, the version u had while PR had issues which are been resolved now
Closing this PR, hoping to see the new PR soon

@yousefsaad12
Copy link
Contributor Author

check the latest weather.jsx, u currently have merge conflicts with the file, can u update the code and re-submit a PR without any conflicts, the version u had while PR had issues which are been resolved now Closing this PR, hoping to see the new PR soon

i make it check it please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crypto.jsx: Format numbers with utility function

2 participants