Skip to content

Conversation

@bearomorphism
Copy link
Contributor

@bearomorphism bearomorphism commented Sep 14, 2025

Description

Checklist

Code Changes

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed
  • Update the documentation for the changes

Documentation Changes

  • Run poetry doc locally to ensure the documentation pages renders correctly
  • Check and fix any broken links (internal or external) in the documentation

When running poetry doc, any broken internal documentation links will be reported in the console output like this:

INFO    -  Doc file 'config.md' contains a link 'commands/bump.md#-post_bump_hooks', but the doc 'commands/bump.md' does not contain an anchor '#-post_bump_hooks'.

Expected Behavior

Steps to Test This Pull Request

Additional Context

@codecov
Copy link

codecov bot commented Sep 14, 2025

Codecov Report

❌ Patch coverage is 97.05882% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (v4-9-2@a472bea). Learn more about missing BASE report.

Files with missing lines Patch % Lines
commitizen/config/__init__.py 95.65% 1 Missing ⚠️
commitizen/config/factory.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             v4-9-2    #1601   +/-   ##
=========================================
  Coverage          ?   98.25%           
=========================================
  Files             ?       59           
  Lines             ?     2690           
  Branches          ?        0           
=========================================
  Hits              ?     2643           
  Misses            ?       47           
  Partials          ?        0           
Flag Coverage Δ
unittests 98.25% <97.05%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bearomorphism bearomorphism marked this pull request as draft September 15, 2025 02:33
@bearomorphism bearomorphism marked this pull request as ready for review September 15, 2025 05:06
@Lee-W Lee-W added this to the 4.9.2 milestone Sep 15, 2025
@bearomorphism bearomorphism changed the base branch from master to v4-9-2 September 18, 2025 17:54
@Lee-W Lee-W modified the milestones: 4.10.1, 4.10.0 Sep 19, 2025
@bearomorphism bearomorphism force-pushed the refactor-config branch 2 times, most recently from 44419b9 to 02d15ef Compare September 20, 2025 11:33
@Lee-W Lee-W changed the title refactor(BaseConfig): update docstring, extract factory method and re… refactor(BaseConfig): update docstring, extract factory method and remove unnecessary variable assignment Nov 8, 2025
@Lee-W Lee-W merged commit 1ec5dc4 into commitizen-tools:v4-9-2 Nov 8, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants