Merged
Conversation
stefmolin
force-pushed
the
py.typed
branch
2 times, most recently
from
e278156 to
f462297
Compare
Contributor
Author
|
The checks are failing on untouched files (images in the docs). |
woile
approved these changes
May 20, 2024
Member
Yep, that will be fixed by #1126 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1127 +/- ##
==========================================
+ Coverage 97.33% 97.58% +0.24%
==========================================
Files 42 55 +13
Lines 2104 2486 +382
==========================================
+ Hits 2048 2426 +378
- Misses 56 60 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Lee-W
approved these changes
May 20, 2024
Lee-W
requested changes
May 20, 2024
Member
Lee-W
left a comment
Lee-W
left a comment
There was a problem hiding this comment.
@stefmolin I think this is not really a fix we need to bump a version and include the changelog. Could you please change the type in the commit message to style instead?
Lee-W
added
pr-status: ready-to-merge
Lee-W
approved these changes
May 20, 2024
Member
|
@stefmolin Thank you for your quick update 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added missing
py.typedfile. Fixes #1106Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
Steps to Test This Pull Request
Additional context