Skip to content

feat: add no-raise option #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2022
Merged

feat: add no-raise option #25

merged 1 commit into from
May 4, 2022

Conversation

woile
Copy link
Member

@woile woile commented Apr 29, 2022

Closes #21 #19

Copy link

@asionek asionek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Kurt-von-Laven Kurt-von-Laven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pre-existing decision, but is there a security reason I'm missing not to take a more general approach and ferry an arbitrary string of arguments through to cz and/or cz bump (c.f., https://github.com/pre-commit/action#using-this-action-with-custom-invocations)?

Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also, I think @Kurt-von-Laven 's suggestion is great!

@woile
Copy link
Member Author

woile commented May 4, 2022

is there a security reason I'm missing not to take a more general approach and ferry an arbitrary string of arguments through to cz and/or cz bump

Not that I know. I think our current way is more verbose, making relatively easier to use this action. While just ferrying the arguments means you have to go and review commitizen docs.

@woile woile force-pushed the feat/add-no-raise branch 2 times, most recently from cb518e8 to c699e3b Compare May 4, 2022 05:23
@woile woile force-pushed the feat/add-no-raise branch from c699e3b to 1ee6ed8 Compare May 4, 2022 05:49
@woile woile merged commit 8ae943d into master May 4, 2022
@Kurt-von-Laven
Copy link
Contributor

That is certainly true, but it seems easier to simply link to the Commitizen docs than to maintain a less detailed copy of them. Totally up to you all obviously. I'm not the one doing the extra work here after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option pass on NoCommitsFoundError
4 participants