-
Notifications
You must be signed in to change notification settings - Fork 43
feat: add no-raise option #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3054bfb
to
669b70a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a pre-existing decision, but is there a security reason I'm missing not to take a more general approach and ferry an arbitrary string of arguments through to cz
and/or cz bump
(c.f., https://github.com/pre-commit/action#using-this-action-with-custom-invocations)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Also, I think @Kurt-von-Laven 's suggestion is great!
Not that I know. I think our current way is more verbose, making relatively easier to use this action. While just ferrying the arguments means you have to go and review |
cb518e8
to
c699e3b
Compare
That is certainly true, but it seems easier to simply link to the Commitizen docs than to maintain a less detailed copy of them. Totally up to you all obviously. I'm not the one doing the extra work here after all. |
Closes #21 #19