Skip to content

feat: optional push and commit input #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2021
Merged

feat: optional push and commit input #16

merged 1 commit into from
Nov 17, 2021

Conversation

nbrugger-tgm
Copy link
Contributor

Implementation of #15

@nbrugger-tgm nbrugger-tgm marked this pull request as draft November 12, 2021 09:54
@nbrugger-tgm nbrugger-tgm marked this pull request as ready for review November 12, 2021 11:19
@nbrugger-tgm
Copy link
Contributor Author

@woile
Copy link
Member

woile commented Nov 12, 2021

Awesome work!

@nbrugger-tgm
Copy link
Contributor Author

Had to re-commit since tests didn't work with a fork->upstream PR

@nbrugger-tgm
Copy link
Contributor Author

nbrugger-tgm commented Nov 12, 2021

Ok so the test indeed passes (tested it on my fork) but i dont know how to get running in a fork pr. I am quite a noob in git cli. Maybe can you find a way to fix the testcase to work for forke branches?

Sorry for the inconvenience

@nbrugger-tgm
Copy link
Contributor Author

nbrugger-tgm commented Nov 17, 2021

Sorry made a mistake, tested in on my repo and it worked (commit b585c72). https://github.com/nbrugger-tgm/commitizen-action/pull/3

I am sorry about the inconvenience but testing workflows especialy with forks etc is a little pain

@woile
Copy link
Member

woile commented Nov 17, 2021

No problem, thanks a lot actually for taking the time to do this. Can I ask you to squash into a single commit?
Thanks!

test: add test for `push` and `commit` inputs
fix: test action commit failing
fix: bash condtion
fix: tag not found on test
test: add echo for debugging to workflow
fix: wrong test condition
fix: missing log for new option
fix: bash scripting syntax
fix: commit input being inverted
fix: inverted commit input
fix: use the branch name instead of HEAD

I have no idea why after checkout 'HEAD' sha is not the same as  `origin/head_ref` but whatever
fix(ci): test script not working on fork
fix(ci): checking out non origin branch
fix(ci): testing local state in push check

Testing the push should only be done on the remote/origin
@woile woile merged commit c355ee1 into commitizen-tools:master Nov 17, 2021
@woile
Copy link
Member

woile commented Nov 17, 2021

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants