Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug on FasterXML/jackson-databind on arrayNode adding null values. #441

Closed
heshamMassoud opened this issue Sep 5, 2019 · 4 comments
Closed

Bug on FasterXML/jackson-databind on arrayNode adding null values. #441

heshamMassoud opened this issue Sep 5, 2019 · 4 comments
Labels
enhancement ⬆️ product-sync question ❓

Comments

@heshamMassoud
Copy link
Contributor

Description

The test resolveAttributeReference_WithNullReferenceInSetAttribute_ShouldResolveReferences is disabled due to a possible bug on FasterXML/jackson-databind#2442.

This was added in this PR: #439

It should be investigated whether we should handle this bug on the library or wait for fix while documenting it's consequences on the library's usage.
@heshamMassoud heshamMassoud mentioned this issue Sep 5, 2019
Merged
3 tasks
@cowtowncoder
Copy link

Fix was included in Jackson 2.10.0 release which is now available.

@heshamMassoud
Copy link
Contributor Author

Great news! @cowtowncoder thanks

@cowtowncoder
Copy link

Thank you for your help, was a good fix!

@heshamMassoud heshamMassoud mentioned this issue Oct 8, 2019
Merged
3 tasks
heshamMassoud added a commit that referenced this issue Oct 16, 2019
@heshamMassoud
#441: Bump JVM SDK.
4256d26
heshamMassoud added a commit that referenced this issue Oct 16, 2019
@heshamMassoud
#441: Enable disabled tests.
1c0fad8
@heshamMassoud heshamMassoud mentioned this issue Oct 16, 2019
Merged
heshamMassoud added a commit that referenced this issue Oct 16, 2019
@heshamMassoud
#441: Fix assertions.
3c3a748
heshamMassoud added a commit that referenced this issue Oct 16, 2019
@heshamMassoud
#441: Bump JVM SDK
bdc51bb
@heshamMassoud
Copy link
Contributor Author

released in https://github.com/commercetools/commercetools-sync-java/releases/tag/1.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ⬆️ product-sync question ❓
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cowtowncoder @heshamMassoud