#441: Enable disabled tests.

commercetools · Oct 16, 2019 · 1c0fad8 · 1c0fad8
1 parent 4256d26
commit 1c0fad8
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/src/test/java/com/commercetools/sync/products/helpers/ProductBatchProcessorTest.java b/src/test/java/com/commercetools/sync/products/helpers/ProductBatchProcessorTest.java
@@ -12,7 +12,6 @@
 import io.sphere.sdk.products.ProductVariantDraftBuilder;
 import io.sphere.sdk.products.attributes.AttributeDraft;
 import org.junit.jupiter.api.BeforeEach;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 import java.util.ArrayList;
@@ -325,7 +324,6 @@ void getProductKeyFromReference_WithoutAProductReference_ShouldReturnEmptyOpt()
         assertThat(result).isEmpty();
     }
 
-    @Disabled("Fails due to bug on https://github.com/FasterXML/jackson-databind/issues/2442")
     @Test
     void getReferencedProductKeysFromSet_WithOnlyNullRefsInSet_ShouldReturnEmptySet() {
         final AttributeDraft productReferenceSetAttribute =

diff --git a/src/test/java/com/commercetools/sync/products/helpers/VariantReferenceResolverTest.java b/src/test/java/com/commercetools/sync/products/helpers/VariantReferenceResolverTest.java
@@ -24,7 +24,6 @@
 import io.sphere.sdk.types.CustomFieldsDraft;
 import io.sphere.sdk.utils.MoneyImpl;
 import org.junit.jupiter.api.BeforeEach;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 import java.math.BigDecimal;
@@ -334,7 +333,6 @@ void resolveReferences_WithMixedReferences_ShouldResolveReferenceAttributes() {
             .isEqualTo(Customer.referenceTypeId());
     }
 
-    @Disabled("Fails due to possible bug on https://github.com/FasterXML/jackson-databind/issues/2442")
     @Test
     void resolveReferences_WithNullReferenceInSetAttribute_ShouldResolveReferences() {
         // preparation
@@ -370,7 +368,7 @@ void resolveReferences_WithNullReferenceInSetAttribute_ShouldResolveReferences()
         final ObjectNode resolvedReference = JsonNodeFactory.instance.objectNode();
         resolvedReference.put(REFERENCE_TYPE_ID_FIELD, Product.referenceTypeId());
         resolvedReference.put(REFERENCE_ID_FIELD, PRODUCT_ID);
-        assertThat(resolvedSet).containsExactly(resolvedReference);
+        assertThat(resolvedSet).containsExactlyInAnyOrder(resolvedReference, JsonNodeFactory.instance.nullNode());
     }
 
     @Test