Skip to content

Add tsup as builder #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add tsup as builder #603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6b726d6
Add tsup as builder and move lodash to lodash-es
acasazza Mar 7, 2025
12579f0
v4.21.0-beta.0
acasazza Mar 7, 2025
59d3d8d
Fix build
acasazza Mar 7, 2025
80119f6
v4.21.0-beta.1
acasazza Mar 7, 2025
9a4ebf9
Fix tsup
acasazza Mar 16, 2025
0a0324c
v4.21.0-beta.2
acasazza Mar 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lerna.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"$schema": "node_modules/lerna/schemas/lerna-schema.json",
"useNx": false,
"npmClient": "pnpm",
"version": "4.20.1",
"version": "4.21.0-beta.2",
"command": {
"version": {
"preid": "beta"
Expand Down
5 changes: 4 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,10 @@
"ws@>=8.0.0 <8.17.1": ">=8.17.1",
"micromatch@<4.0.8": ">=4.0.8",
"rollup@>=4.0.0 <4.22.4": ">=4.22.4",
"cross-spawn@>=7.0.0 <7.0.5": ">=7.0.5"
"cross-spawn@>=7.0.0 <7.0.5": ">=7.0.5",
"store2@<2.14.4": ">=2.14.4",
"@octokit/request@>=1.0.0 <9.2.1": ">=9.2.1",
"esbuild@<=0.24.2": ">=0.25.0"
}
}
}
173 changes: 19 additions & 154 deletions packages/react-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,180 +1,42 @@
{
"name": "@commercelayer/react-components",
"version": "4.20.1",
"version": "4.21.0-beta.2",
"description": "The Official Commerce Layer React Components",
"main": "lib/cjs/index.js",
"module": "lib/esm/index.js",
"types": "lib/esm/index.d.ts",
"type": "module",
"module": "dist/index.js",
"types": "dist/index.d.ts",
"files": [
"lib",
"dist",
"package.json",
"README.md"
],
"exports": {
"./package.json": "./package.json",
".": {
"require": "./lib/cjs/index.js",
"import": "./lib/esm/index.js"
},
"./addresses/*": {
"require": "./lib/cjs/components/addresses/*.js",
"import": "./lib/esm/components/addresses/*.js"
},
"./auth/*": {
"require": "./lib/cjs/components/auth/*.js",
"import": "./lib/esm/components/auth/*.js"
},
"./customers/*": {
"require": "./lib/cjs/components/customers/*.js",
"import": "./lib/esm/components/customers/*.js"
},
"./errors/*": {
"require": "./lib/cjs/components/errors/*.js",
"import": "./lib/esm/components/errors/*.js"
},
"./gift_cards/*": {
"require": "./lib/cjs/components/gift_cards/*.js",
"import": "./lib/esm/components/gift_cards/*.js"
},
"./in_stock_subscriptions/*": {
"require": "./lib/cjs/components/in_stock_subscriptions/*.js",
"import": "./lib/esm/components/in_stock_subscriptions/*.js"
},
"./hooks/*": {
"require": "./lib/cjs/hooks/*.js",
"import": "./lib/esm/hooks/*.js"
},
"./line_items/*": {
"require": "./lib/cjs/components/line_items/*.js",
"import": "./lib/esm/components/line_items/*.js"
},
"./orders/*": {
"require": "./lib/cjs/components/orders/*.js",
"import": "./lib/esm/components/orders/*.js"
},
"./parcels/*": {
"require": "./lib/cjs/components/parcels/*.js",
"import": "./lib/esm/components/parcels/*.js"
},
"./payment_methods/*": {
"require": "./lib/cjs/components/payment_methods/*.js",
"import": "./lib/esm/components/payment_methods/*.js"
},
"./payment_source/*": {
"require": "./lib/cjs/components/payment_source/*.js",
"import": "./lib/esm/components/payment_source/*.js"
},
"./prices/*": {
"require": "./lib/cjs/components/prices/*.js",
"import": "./lib/esm/components/prices/*.js"
},
"./shipments/*": {
"require": "./lib/cjs/components/shipments/*.js",
"import": "./lib/esm/components/shipments/*.js"
},
"./shipping_methods/*": {
"require": "./lib/cjs/components/shipping_methods/*.js",
"import": "./lib/esm/components/shipping_methods/*.js"
},
"./skus/*": {
"require": "./lib/cjs/components/skus/*.js",
"import": "./lib/esm/components/skus/*.js"
},
"./stock_transfers/*": {
"require": "./lib/cjs/components/stock_transfers/*.js",
"import": "./lib/esm/components/stock_transfers/*.js"
},
"./context/*": {
"require": "./lib/cjs/context/*.js",
"import": "./lib/esm/context/*.js"
},
"./utils/*": {
"require": "./lib/cjs/utils/*.js",
"import": "./lib/esm/utils/*.js"
},
"./component_utils/*": {
"require": "./lib/cjs/components/utils/*.js",
"import": "./lib/esm/components/utils/*.js"
"import": "./dist/index.js",
"default": "./dist/index.cjs"
}
},
"typesVersions": {
"*": {
"addresses/*": [
"lib/esm/components/addresses/*.d.ts"
],
"auth/*": [
"lib/esm/components/auth/*.d.ts"
],
"customers/*": [
"lib/esm/components/customers/*.d.ts"
],
"errors/*": [
"lib/esm/components/errors/*.d.ts"
],
"gift_cards/*": [
"lib/esm/components/gift_cards/*.d.ts"
],
"in_stock_subscriptions/*": [
"lib/esm/components/in_stock_subscriptions/*.d.ts"
],
"hooks/*": [
"lib/esm/hooks/*.d.ts"
],
"line_items/*": [
"lib/esm/components/line_items/*.d.ts"
],
"orders/*": [
"lib/esm/components/orders/*.d.ts"
],
"parcels/*": [
"lib/esm/components/parcels/*.d.ts"
],
"payment_methods/*": [
"lib/esm/components/payment_methods/*.d.ts"
],
"payment_source/*": [
"lib/esm/components/payment_source/*.d.ts"
],
"prices/*": [
"lib/esm/components/prices/*.d.ts"
],
"shipments/*": [
"lib/esm/components/shipments/*.d.ts"
],
"shipping_methods/*": [
"lib/esm/components/shipping_methods/*.d.ts"
],
"skus/*": [
"lib/esm/components/skus/*.d.ts"
],
"stock_transfers/*": [
"lib/esm/components/stock_transfers/*.d.ts"
],
"context/*": [
"lib/esm/context/*.d.ts"
],
"utils/*": [
"lib/esm/utils/*.d.ts"
],
"component_utils/*": [
"lib/esm/components/utils/*.d.ts"
]
}
"engines": {
"node": ">=18",
"pnpm": ">=7"
},
"publishConfig": {
"access": "public"
},
"scripts": {
"lint": "biome lint --error-on-warnings ./src",
"lint:fix": "pnpm biome lint --write ./src",
"lint:tsc": "tsc",
"test": "pnpm audit --audit-level high && (pnpm audit || exit 0) && pnpm lint && vitest run --silent",
"coverage": "vitest run --coverage",
"test:e2e": "NODE_ENV=test playwright test",
"test:e2e:coverage": "nyc pnpm test:e2e && pnpm coverage:report",
"coverage:report": "nyc report --reporter=html",
"build": "tsc -b tsconfig.prod.json tsconfig.prod.esm.json --verbose && pnpm postbuild",
"build": "tsup && pnpm lint:tsc",
"build:dev": "tsc -b tsconfig.prod.json tsconfig.prod.esm.json --verbose && tsc-alias -p tsconfig.prod.json && tsc-alias -p tsconfig.prod.esm.json",
"postbuild": "tsc-alias -p tsconfig.prod.json && tsc-alias -p tsconfig.prod.esm.json && minimize-js lib -w -s -b '\"use client\";'",
"dev": "NODE_OPTIONS='--inspect' next dev"
"dev": "NODE_OPTIONS='--inspect' next dev",
"check-exports": "attw --pack ."
},
"repository": {
"type": "git",
Expand Down Expand Up @@ -210,17 +72,19 @@
"frames-react": "^1.2.2",
"iframe-resizer": "^4.3.6",
"jwt-decode": "^4.0.0",
"lodash": "^4.17.21",
"lodash-es": "^4.17.21",
"rapid-form": "2.1.0"
},
"devDependencies": {
"@arethetypeswrong/cli": "^0.17.4",
"@commercelayer/js-auth": "^6.7.1",
"@faker-js/faker": "^9.5.1",
"@playwright/test": "^1.50.1",
"@testing-library/dom": "^10.4.0",
"@testing-library/react": "^16.2.0",
"@types/braintree-web": "^3.96.16",
"@types/lodash": "^4.17.16",
"@types/lodash-es": "^4.17.12",
"@types/node": "^22.13.9",
"@types/prop-types": "^15.7.14",
"@types/react": "^18.3.1",
Expand All @@ -236,6 +100,7 @@
"react-test-renderer": "^18.3.1",
"tsc-alias": "^1.8.11",
"tslib": "^2.8.1",
"tsup": "^8.4.0",
"typescript": "^5.8.2",
"vite": "^6.2.0",
"vite-tsconfig-paths": "^5.1.4",
Expand Down
19 changes: 10 additions & 9 deletions packages/react-components/src/components/SubmitButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,26 @@
import type { ReactNode, JSX } from 'react';
import Parent from '#components/utils/Parent'
import type { ChildrenFunction } from '#typings/index'
import isFunction from 'lodash/isFunction'
import type { ReactNode, JSX } from "react"
import Parent from "#components/utils/Parent"
import type { ChildrenFunction } from "#typings/index"
import isFunction from "lodash-es/isFunction"

interface ChildrenProps extends Omit<Props, 'children'> {}
interface ChildrenProps extends Omit<Props, "children"> {}

interface Props extends Omit<JSX.IntrinsicElements['button'], 'children' | 'ref'> {
interface Props
extends Omit<JSX.IntrinsicElements["button"], "children" | "ref"> {
children?: ChildrenFunction<ChildrenProps>
label?: string | ReactNode
}

export function SubmitButton(props: Props): JSX.Element {
const { children, label = 'Submit', ...p } = props
const { children, label = "Submit", ...p } = props
const parentProps = {
...p,
label
label,
}
return children ? (
<Parent {...parentProps}>{children}</Parent>
) : (
<button type='submit' {...p}>
<button type="submit" {...p}>
{isFunction(label) ? label() : label}
</button>
)
Expand Down
Loading
Loading