Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plumb status updates through event handler #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Mar 14, 2025

This will allow users to disable the event handler and silence the currently unconditional console output.

Closes #37

@cottsay cottsay added the enhancement New feature or request label Mar 14, 2025
@cottsay cottsay added this to the 0.3.1 milestone Mar 14, 2025
@cottsay cottsay self-assigned this Mar 14, 2025
This will allow users to disable the event handler and silence the
currently unconditional console output.
@cottsay cottsay force-pushed the cottsay/parallel-status-event branch from f30518a to 1efb41b Compare March 14, 2025 22:23
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 21.05263% with 15 lines in your changes missing coverage. Please review.

Project coverage is 73.33%. Comparing base (f52f1b4) to head (1efb41b).

Files with missing lines Patch % Lines
...parallel_executor/event_handler/parallel_status.py 0.00% 13 Missing ⚠️
colcon_parallel_executor/event/executor.py 75.00% 1 Missing ⚠️
colcon_parallel_executor/executor/parallel.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   80.30%   73.33%   -6.97%     
==========================================
  Files           2        4       +2     
  Lines         132      150      +18     
  Branches       40       43       +3     
==========================================
+ Hits          106      110       +4     
- Misses         16       30      +14     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

[Processing: package_name] cannot be disabled via --event-handlers toggles
2 participants