Skip to content

fix(DEX2-898): Break up reveal and transition animation props#355

Open
avocado-cb wants to merge 1 commit intocoinbase:masterfrom
avocado-cb:tristyn/reveal-animation
Open

fix(DEX2-898): Break up reveal and transition animation props#355
avocado-cb wants to merge 1 commit intocoinbase:masterfrom
avocado-cb:tristyn/reveal-animation

Conversation

@avocado-cb
Copy link
Contributor

@avocado-cb avocado-cb commented Feb 1, 2026

What changed? Why?

I have noticed that at various times the chart animations have been disabled by developers to avoid odd looking transitions from new candles: Example Instance. However this also disables the reveal animation as collateral damage.

This breaks up the prop into 2 to allow disabling only transitions.

Reveal animation shown below.

Screen.Recording.2026-02-01.at.8.47.17.PM.mov

Root cause (required for bugfixes)

UI changes

iOS Old iOS New
old screenshot new screenshot
Android Old Android New
old screenshot new screenshot
Web Old Web New
old screenshot new screenshot

Testing

How has it been tested?

  • Unit tests
  • Interaction tests
  • Pseudo State tests
  • Manual - Web
  • Manual - Android (Emulator / Device)
  • Manual - iOS (Emulator / Device)

Testing instructions

Illustrations/Icons Checklist

Required if this PR changes files under packages/illustrations/** or packages/icons/**

  • verified visreg changes with Terran (include link to visreg run/approval)
  • all illustration/icons names have been reviewed by Dom and/or Terran

Change management

type=routine
risk=low
impact=sev5

automerge=false

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Feb 1, 2026

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 1
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1
CODEOWNERS 🟡 See below

🟡 CODEOWNERS

Code Owner Status Calculation
ui-systems-eng-team 🟡 0/1
Denominator calculation
Additional CODEOWNERS Requirement
Show calculation
Sum 0
0
From CODEOWNERS 1
Sum 1

@avocado-cb avocado-cb changed the title fix: break up reveal and transition animations fix(DEX2-898): break up reveal and transition animations Feb 1, 2026
@avocado-cb avocado-cb changed the title fix(DEX2-898): break up reveal and transition animations fix(DEX2-898): Break up reveal and transition animation props Feb 1, 2026
@avocado-cb
Copy link
Contributor Author

@hcopp wants to do a much more expressive prop interface

Hey guys, I was talking with Tristyn about CDS Chart transition customization and issues retail has run into.

No customization support for intro/enter transitions

  • Right now you can only customize the update animation for area/line and beacon pulse/movement
  • My proposed solution is to support transitions={{ enter: { ... }, update: { ... } }} prop on LineChart, Line, Area, etc
    • You could do one of these two <Line transitions={{ enter: { duration: 0 }, update: null }} /> to disable a specific transition
  • This could also be expanded to include any sort of transitions
  • This would match our existing transition customization support for ScrubberBeacon transitions (beaconTransitions)
  • This should be a quick implementation, I can refer to Tristyn's PR in CDS repo if y'all are good with this prop structure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants