Draft
Conversation
- upgrade react eslint plugin - migrate CSF2 stories to CSF3 format (https://storybook.js.org/blog/storybook-csf3-is-here/)
… (due to react 19 hook behavior) in packages/common
…ackage migration done
…and react-spring types
…ance of react-test-renderer) and disable new react-hooks eslint rules for now
…ibility enginer and the now deprecated react-test-renderer
…ce ReactNode usage
cb-ekuersch
commented
Jan 30, 2026
package.json
Outdated
| @@ -68,8 +68,6 @@ | |||
| "@testing-library/user-event@^14.0.4": "patch:@testing-library/user-event@npm:14.0.4#.yarn/patches/@testing-library-user-event-npm-14.0.4-109d618170", | |||
| "framer-motion@^10.18.0": "patch:framer-motion@npm:10.18.0#.yarn/patches/framer-motion-npm-10.18.0-ae9ea02138", | |||
| "@expo/cli": "patch:@expo/cli@npm:0.18.29#.yarn/patches/@expo-cli-npm-0.18.29-f58906fdfb.patch", | |||
Contributor
Author
There was a problem hiding this comment.
open android/ios shortcust remove if dont need
cb-ekuersch
commented
Jan 30, 2026
package.json
Outdated
| "@expo/cli": "patch:@expo/cli@npm:0.18.29#.yarn/patches/@expo-cli-npm-0.18.29-f58906fdfb.patch", | ||
| "react-native": "patch:react-native@npm:0.74.5#.yarn/patches/react-native-npm-0.74.5-db5164f47b.patch", | ||
| "react-native-gesture-handler": "patch:react-native-gesture-handler@npm:2.16.2#.yarn/patches/react-native-gesture-handler-npm-2.16.2-c16529326b.patch", | ||
| "expo-splash-screen": "patch:expo-splash-screen@npm:0.27.5#.yarn/patches/expo-splash-screen-npm-0.27.5-f91e0b41df.patch", |
Contributor
Author
There was a problem hiding this comment.
delete - fixed expo-splash-screen
cb-ekuersch
commented
Jan 30, 2026
| "react-native": "patch:react-native@npm:0.74.5#.yarn/patches/react-native-npm-0.74.5-db5164f47b.patch", | ||
| "react-native-gesture-handler": "patch:react-native-gesture-handler@npm:2.16.2#.yarn/patches/react-native-gesture-handler-npm-2.16.2-c16529326b.patch", | ||
| "expo-splash-screen": "patch:expo-splash-screen@npm:0.27.5#.yarn/patches/expo-splash-screen-npm-0.27.5-f91e0b41df.patch", | ||
| "react-native-navigation-bar-color": "patch:react-native-navigation-bar-color@npm:2.0.2#.yarn/patches/react-native-navigation-bar-color-npm-2.0.2-9a2ea3aaf6.patch", |
cb-ekuersch
commented
Jan 30, 2026
package.json
Outdated
| "react-native-gesture-handler": "patch:react-native-gesture-handler@npm:2.16.2#.yarn/patches/react-native-gesture-handler-npm-2.16.2-c16529326b.patch", | ||
| "expo-splash-screen": "patch:expo-splash-screen@npm:0.27.5#.yarn/patches/expo-splash-screen-npm-0.27.5-f91e0b41df.patch", | ||
| "react-native-navigation-bar-color": "patch:react-native-navigation-bar-color@npm:2.0.2#.yarn/patches/react-native-navigation-bar-color-npm-2.0.2-9a2ea3aaf6.patch", | ||
| "expo-dev-launcher": "patch:expo-dev-launcher@npm:4.0.27#.yarn/patches/expo-dev-launcher-npm-4.0.27-c2ab5dd4a5.patch", |
Contributor
Author
There was a problem hiding this comment.
dont need fix - resolved
…y from react-test-renderer - remove jest-native from preset and package.json (deprecated in favor of RNTL built-in matchers) - migrate toHaveAccessibilityState to granular matchers (toBeChecked, toBeSelected, toBeDisabled) - convert Link.test.tsx prop tests to behavioral tests using mocked useWebBrowserOpener - skip InputStack.test.tsx prop forwarding tests (implementation details not testable via host elements) - replace ReactTestInstance type import in ProgressBar.test.tsx with RNTL-compatible type
…llow for patched React 19.1 versions
…ncorrect imports and update web unit test tests, following react downgrade in previous commit
- Add `{ includeHiddenElements: true }` to queries for elements with
`accessibilityElementsHidden={true}` or `aria-hidden={true}`
- Replace `UNSAFE_queryAllByType(Pressable)` implementation detail tests
with behavioral tests using `fireEvent.press`
- Update NativeEventEmitter mock to return subscription objects with
`.remove()` method for KeyboardAvoidingView compatibility
- Replace deprecated `SafeAreaView` from react-native with
`react-native-safe-area-context` in Modal components
- Refactor useAppState tests to use `jest.spyOn` instead of `jest.doMock`
with dynamic imports
- Change `.toBe()` to `.toContainEqual()` for style array comparisons
- Use regex patterns for partial text matching with `toHaveTextContent`
- Update `.parent` to `.parent.parent` for correct element traversal
- Remove animated style assertions that no longer work with reanimated 4.x
- Drop tests requiring complex Platform/StatusBar native module mocking
- Drop deprecated CellMedia component tests using UNSAFE_getByType(Image)
- Update expected tooltip position values after calculation changes
- Fix `fireEvent.click` to `fireEvent.press` in React Native tests
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…d for RN requirements)
* Ran CMRv7 setup command to set compatible version deps and resolved failing yarn constraints check * remove odd react-dom peer dep on common package * Add new yarn constraint to force dev deps on peer deps and fix all yarn constraints & improve clarity of errors reported from consistent version numbers constraint * remove unused peer desps of cds-mobile * new app: test-expo for mobile testing with build scripts for easy ios and android simulator testing and options to build for release as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Root cause (required for bugfixes)
UI changes
Testing
How has it been tested?
Testing instructions
Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false