Open
Conversation
Collaborator
🟡 Heimdall Review Status
🟡
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
🟡
0/1
|
Denominator calculation
|
hcopp
commented
Jan 30, 2026
| key: 'ATrayStandard', | ||
| getComponent: () => | ||
| require('@coinbase/cds-mobile/overlays/__stories__/ATrayStandard.stories').default, | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
Will move these down after bug bash
Contributor
Author
There was a problem hiding this comment.
Will move them when we get closer to release
hcopp
commented
Jan 30, 2026
| style={{ shadowOffset: { width: 0, height: -32 }, shadowOpacity: 0.05 }} | ||
| > | ||
| <Button compact onPress={() => setOpen(false)}> | ||
| <Button compact onPress={handleClose}> |
Contributor
Author
There was a problem hiding this comment.
This was a bug where when you click "done" it would immediately close, rather than animating.
hcopp
commented
Feb 4, 2026
| return children; | ||
| } | ||
| return <LazyMotion features={domMax}>{children}</LazyMotion>; | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
We use LazyMotion with domMax for drag, this is needed for Carousel as well.
However, I didn't want to automatically add this, I worry it could potentially cause issues for the existing users. So it is opt in for now, curious on other's thoughts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This PR updates our Tray, prioritizing backwards compatibility where possible
That said, there are a few expected breaking changes
Functionality added
Web
Mobile
I could see us in v9 adopting this new version for mobile Select and Combobox (which uses Tray) and in v10 dropping support for the now deprecated versions.
UI changes
OG Tray Code Changes
Only expected change here is slight border radius change.
New Tray Styles
Mobile
Web
Testing
Test out old tray examples to ensure they still work properly and compare new examples with design examples.
How has it been tested?
Testing instructions
Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false