Open
Conversation
adrienzheng-cb
force-pushed
the
adrien/media-card
branch
from
2974a71 to
776916b
Compare
adrienzheng-cb
force-pushed
the
adrien/messaging-card
branch
from
fe3d127 to
b731529
Compare
adrienzheng-cb
force-pushed
the
adrien/media-card
branch
from
776916b to
7292037
Compare
adrienzheng-cb
force-pushed
the
adrien/messaging-card
branch
from
b731529 to
5b77c22
Compare
adrienzheng-cb
force-pushed
the
adrien/media-card
branch
4 times, most recently
from
b8ba62a to
a1c36fd
Compare
adrienzheng-cb
force-pushed
the
adrien/messaging-card
branch
from
5b77c22 to
213b21d
Compare
adrienzheng-cb
force-pushed
the
adrien/media-card
branch
from
a1c36fd to
a242eaa
Compare
adrienzheng-cb
force-pushed
the
adrien/messaging-card
branch
from
213b21d to
93d5bcf
Compare
cb-ekuersch
reviewed
Jan 26, 2026
| } | ||
| // when media is placed at the end, we need to add additional padding to the end of the media container | ||
| // this is to avoid the dismiss button from overlapping with the media | ||
| return onDismiss |
Contributor
There was a problem hiding this comment.
nit: just a random idea, but for situations like this, I wonder if it would be more obvious what it is we're going for if we rendered a spacer element instead of adjusting the style of an otherwise unrelated element to the dismiss. The element could be called like dismissSpacer or something else descriptive
Contributor
There was a problem hiding this comment.
also should the Root card component encapsulate the dismiss button?
Contributor
Author
There was a problem hiding this comment.
dismiss is a feature unique to MessagingCard, which is why it is not at the root.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Root cause (required for bugfixes)
UI changes
docs
storybook
Testing
How has it been tested?
Testing instructions
Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false