Skip to content

feat(coinbase-mcp): add agent controls guidance for orders and payments - #21

Open
apmcdermott wants to merge 2 commits into
mainfrom
feat/mcp-agent-controls-guidance
Open

apmcdermott wants to merge 2 commits into
mainfrom
feat/mcp-agent-controls-guidance

Conversation

@apmcdermott

@apmcdermott apmcdermott commented Nov 13, 2026 •

Copy link
Copy Markdown

Description

Adds guidance for the coinbase_agent_controls_get tool, which returns the user's spend limits and whether the app is paused. It only applies where the server exposes the tool.

  • references/trading.md: read the controls before previewing an order. Stop if pause_status is yes, treat unknown as possibly paused, and compare the order with max (per order) or remaining (rolling). Adds the tool to the tool table.
  • references/x402.md: check x402_payment limits and pause_status before paying.
  • SKILL.md: don't split or reroute an action to get around a spend-limit or paused refusal.
  • CHANGELOG.md: one entry.

Change type

  • Harness integration or metadata
  • Skill workflow
  • Bug fix
  • Documentation
  • Breaking change (describe migration)

Validation

  • python3 -m unittest discover -s tests: 38 tests pass.

  • python3 scripts/build-distributions.py: builds; the guidance is in every package.

  • Not run: native harness loading.

  • Generated portable manifest and MCP config validate against the vendored Agent Plugins schemas

  • Package paths and skill references remain inside each generated plugin root

  • Marketplace, skills, MCP, and icon paths are valid

  • Exactly one canonical skill library; generated copies are not committed

  • Claude compatibility metadata/endpoint and marketplace sources agree with the portable package

  • Tool schemas, authorization, and retry behavior reviewed

  • README and changelog updated; versions consistent

  • No unapproved disclosures or sensitive data

  • Signed commits

Release considerations

None.

@cb-heimdall

cb-heimdall commented Nov 13, 2026 •

Copy link
Copy Markdown

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
1 if authored by an app that is not allowlisted and lacks verified human attribution 0
Sum 1

⚠️ Ignored Reviews (1)

Reviewer Reason
ethanoroshiba Soft review, as user does not have write permissions

@apmcdermott
apmcdermott force-pushed the feat/mcp-agent-controls-guidance branch from 3acb33f to bd53329 Compare November 20, 2026 00:04
@cb-heimdall

Copy link
Copy Markdown

Review Error for ethanoroshiba @ 2026-11-20 17:48:49 UTC
User failed mfa authentication, see go/mfa-help

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants