Repository navigation
feat(coinbase-mcp): add agent controls guidance for orders and payments - #21
Open
apmcdermott wants to merge 2 commits into
Open
apmcdermott wants to merge 2 commits into
apmcdermott wants to merge 2 commits into
Conversation
🟡 Heimdall Review Status
|
apmcdermott
force-pushed
the
feat/mcp-agent-controls-guidance
branch
from
November 20, 2026 00:04
3acb33f to
bd53329
Compare
ethanoroshiba
approved these changes
Nov 20, 2026
|
Review Error for ethanoroshiba @ 2026-11-20 17:48:49 UTC |
ethanoroshiba
approved these changes
Nov 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds guidance for the
coinbase_agent_controls_gettool, which returns the user's spend limits and whether the app is paused. It only applies where the server exposes the tool.references/trading.md: read the controls before previewing an order. Stop ifpause_statusisyes, treatunknownas possibly paused, and compare the order withmax(per order) orremaining(rolling). Adds the tool to the tool table.references/x402.md: checkx402_paymentlimits andpause_statusbefore paying.SKILL.md: don't split or reroute an action to get around a spend-limit or paused refusal.CHANGELOG.md: one entry.Change type
Validation
python3 -m unittest discover -s tests: 38 tests pass.python3 scripts/build-distributions.py: builds; the guidance is in every package.Not run: native harness loading.
Generated portable manifest and MCP config validate against the vendored Agent Plugins schemas
Package paths and skill references remain inside each generated plugin root
Marketplace, skills, MCP, and icon paths are valid
Exactly one canonical skill library; generated copies are not committed
Claude compatibility metadata/endpoint and marketplace sources agree with the portable package
Tool schemas, authorization, and retry behavior reviewed
README and changelog updated; versions consistent
No unapproved disclosures or sensitive data
Signed commits
Release considerations
None.