Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] [bk] Add configuration parameters related to the maximum compaction duration to the bookkeeper.conf #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sandeep-mst
Copy link
Collaborator

Fixes apache#23818

Motivation

bookkeeper.conf is missing parameters related to maximum compaction duration in apache/pulsar. These parameters are useful for managing bookkeeper compaction in heavy workloads.

Modifications

Added majorCompactionMaxTimeMillis and minorCompactionMaxTimeMillis to conf/bookkeeper.conf so that they can be updated from env variables in pulsar docker containers.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Missing Configuration in bookkeeper.conf
1 participant