Use link reference syntax for overly-long inline links#8
Merged
Conversation
This requires GfM but is far more readable in prose for things like Google Docs links where the link itself is fairly meaningless. Leaves short-enough links alone.
thatch
force-pushed
the
markdown-long-lines
branch
from
d7d7c0b to
fb2bf7f
Compare
jag250
reviewed
Jul 14, 2025
markdown/long_links.py
Outdated
| yield match["node"][0] | ||
|
|
||
| def child_for_type(node, typ): | ||
| return [c for c in node.children if c.type == typ][0] |
There was a problem hiding this comment.
I'm curious as to why this creates a whole list if it only needs the first element
Member
Author
There was a problem hiding this comment.
Either "so it fits on one line" or "laziness" -- updated.
jag250
reviewed
Jul 14, 2025
| # print(buf.decode()) | ||
| Path(f).write_bytes(buf) | ||
|
|
||
| return exit_code |
There was a problem hiding this comment.
I noticed exit_code is never modified. Is it there to enhance readability?
Member
Author
There was a problem hiding this comment.
Leftover from when this just complained about long links rather than fixing them. Readability works.
jag250
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires GfM but is far more readable in prose for things like Google Docs links where the link itself is fairly meaningless. Leaves short-enough links alone.