Skip to content

Conversation

@siddharth25pandey
Copy link

@siddharth25pandey siddharth25pandey commented May 19, 2020

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce ?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@boss-contributions-bot
Copy link

Thanks @siddharth25pandey, for opening the pull request! 🙌

One of our mentors will review the pull request soon. ✅

Star ⭐ this project and tweet 🐦 about your contributions.

@jatinkatyal13
Copy link
Contributor

Please make the PR against project-worker branch and build the project before submitting the PR

@siddharth25pandey
Copy link
Author

changed the same PR in project-worker branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants