feat: Imp[NoteSettings] add func to sort team in correct order #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3388ShubinPavel
commented
Feb 26, 2025
3388ShubinPavel
commented
- Add sortMembers function that sorts members in order Creator -> Writer -> Reader
- Change view to display team from sortedMember array
neSpecc
reviewed
Feb 26, 2025
neSpecc
approved these changes
Feb 26, 2025
e11sy
requested changes
Feb 26, 2025
Comment on lines
+69
to
+70
| const isCreatorA = String(a.user.id) === props.noteId; | ||
| const isCreatorB = String(b.user.id) === props.noteId; |
There was a problem hiding this comment.
user.id should never be equal to noteId
Comment on lines
+79
to
+81
| if (!roleOrder[a.role] && !roleOrder[b.role]) { | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
this condition will work if both roles are write and you will get (!0 && !0) condition
however below you have condition that will return same thing for same data (0 === 0)
so this condition seems redundant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.