fix(ci): introduce a number of integration test fixes #1342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- need to test with longer tests to ensure the parallelisation is truly happening - is the +10 hardhat port needed? - try with more integration tests # Conflicts: # tests/integration/hardhatprocess.nim # tests/integration/multinodes.nim # tests/integration/testcli.nim # tests/testIntegration.nim
# Conflicts: # tests/testIntegration.nim
# Conflicts: # tests/testIntegration.nim
# Conflicts: # tests/testIntegration.nim
# Conflicts: # tests/integration/hardhatprocess.nim
prevents showing error in the logs when an expected process exit code is encountered # Conflicts: # tests/integration/testcli.nim
# Conflicts: # tests/integration/testcli.nim
# Conflicts: # tests/ethertest.nim
- add a TestManager property to IntegrationTest, so manager does not need to be passed into all functions - cleanup: - remove unneeded stopHardhat function - add hardhat instance to manager outside of startHardhat
…error starting hardhat
allows user to know which tests are still running
Work around the AsyncProcess timeout not working correctly
# Conflicts: # tests/testIntegration.nim
# Conflicts: # tests/integration/hardhatprocess.nim
On windows, termination of hardhat processes would not actually kill the process, and then closing the process' streams would then hang the calling nim process. To get around this, the process is now killed externally using a script, winkillhardhat.sh. This script first queries open processes by inspecting the command line value of all "node.exe" processes, searching for "vendor/codex-contracts-eth" and for the port parameter it was started with. After querying, the process is killed using the `Stop-Process` powershell command (passing the pid of the windows process).
… params of eventually With this fix in, there is no need to use the asynctest update that sets longer defaults for eventually, so downgrade asynctest
Since the HttpClient now supports async, re-enable debug logging in the Codex nodes
…ebugHardhat=true Hardhat output is logged to file in hardhat.log for each test, and printing to screen is not necessarily needed as it is already logged to file and can create clutter in the output, so stop writing logging output to memory and writing to screen.
In situations like timeouts, windows will hang when attempting to close the test process streams. In this case, we have to force kill the test process externally. This is the same process as force killing hardhat nodes after they are already terminated, but windows refuses hangs when closing their process streams. This commit creates a forceKillProcess utility that allows a process to be killed by its process name and matching commandline criteria, like TestId (for test process) or --port (for hardhat)
Because `eventuallySafe` calls the symbol `eventually`, it should be declared before `proc eventually` is declared to avoid ambiguous symbol lookups.
Also adds a condition such that a hardhat node is not started for parallel integration tests
It didn't fix the error with invalid proofs in windows in ci
Also, catch exceptions on JsonRpcProvider.close, which should not need to be done, as this routine should not raise any exceptions.
Permission denied creating the symlink in CI
Signed-off-by: Slava <[email protected]>
Not needed for now since parallel integration tests aren't enabled
emizzle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of bugs were encountered in windows CI during development of the parallel integration tests. Fixes for these bugs were ported to this PR without enabling parallel integration tests to see if this alleviates intermittent test failures in windows ci.
Changes include: