chore: fix custom error handling when simulating invalid proofs #1217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emizzle
approved these changes
May 29, 2025
2-towns
force-pushed
the
chore/fix-prooving-custom-error-handling
branch
2 times, most recently
from
08ed65f to
61152ef
Compare
markspanbroek
approved these changes
Jun 2, 2025
2-towns
force-pushed
the
chore/fix-prooving-custom-error-handling
branch
from
61152ef to
5255b92
Compare
2-towns
force-pushed
the
chore/fix-prooving-custom-error-handling
branch
from
5255b92 to
2072c39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the handling of custom errors raised by
submitProofand protects the marketplace abstraction by raising an error inmarket.nimrather thanmarketplace.nim, similar to what was done withSlotReservationNotAllowedError.