feat(marketplace) - add command line arg for maxPriorityFeePerGas

[2-towns]

This PR adds a new command line argument to configure the maxPriorityFeePerGas available now with [EIP-1559 implementation] (codex-storage/nim-ethers#113)

[markspanbroek]

Nice, thanks @2-towns!

[AuHau]

I was a bit hesitant to include some defaults that affect transaction "tips", but actually looking into EIP-1559 and checking the recent priority values on Gas tracker, I see that it is most probably needed in order to get transactions mined in a reasonable timeframe.

Just FYI. ethers.js is, I believe, using for the max priority fee 1,5 gwei as default value and not 1 gwei. To better understand it, I did some digging around this in Dune. For L2 the 1 gwei should be sufficient. The daily average for Arbitrum is bellow 0.1 gwei. You can have a look here: https://dune.com/queries/5234448/8604035/

Btw. on Ethreum mainnet it is between 1.5 to 2.6 gwei 🤪

So all in all, good work! Thanks for picking it up 👍

[AuHau]

Btw. is EIP 1559 available on our PoA network? It is running old version of Geth, but I think it is the last version before The Merge, so it should be available as EIP 1559 was introduced before The Merge if I remember correctly?

But anyhow, nim-ethers will work correctly if EIP 1559 is not available right?

[2-towns]

Btw. is EIP 1559 available on our PoA network? It is running old version of Geth, but I think it is the last version before The Merge, so it should be available as EIP 1559 was introduced before The Merge if I remember correctly?

Yes it should be available, I already checked with Slava, see genesis.json and how to run a private chain with EIP 1559 enabled.

But anyhow, nim-ethers will work correctly if EIP 1559 is not available right?

Yes exactly, it the EIP 1559 is not available, the "old" gas calculation will be used.