feat: Multi threading support for circom prover #1120
Conversation
munna0908
force-pushed
the
feat/async-prover
branch
from
04a34b7 to
ce3a7a0
Compare
| self: CircomCompat, | ||
| proof: CircomProof, | ||
| inputs: ProofInputs[H], | ||
| success: ptr Atomic[bool], |
There was a problem hiding this comment.
I'm not sure why we're passing a pointer to a bool, there is no reason to do this, just use a straight up Atomic[bool]?
There was a problem hiding this comment.
I need to read VerifyResult from the calling procedure, so I'm passing it as a pointer to avoid pass-by-value.
There was a problem hiding this comment.
There is no advantage of using a pointer here at all, copying a pointer is equivalent to copying a bool value? I don't see material difference between this and prove procedure?
| failure("Failed to verify proof - err code: " & $res) | ||
| finally: | ||
| inputs.releaseCircomInputs() | ||
| if error =? (await self.asyncVerify(proof, inputs, res)).errorOption: |
There was a problem hiding this comment.
why not just return a bool here (or even void) and set to false on failure, true otherwise?
There was a problem hiding this comment.
@dryajov To check task completion upon cancellation, I need the response for validation, so I'm passing it as a parameter to asyncVerify.
There was a problem hiding this comment.
The response is either passed or failed, right?
| @@ -52,3 +54,32 @@ func toG2*(g: CircomG2): G2Point = | |||
|
|
|||
| func toGroth16Proof*(proof: CircomProof): Groth16Proof = | |||
| Groth16Proof(a: proof.a.toG1, b: proof.b.toG2, c: proof.c.toG1) | |||
|
|
|||
| proc newProof*(): ptr Proof = | |||
There was a problem hiding this comment.
I think it would be better if we declare this as types and use the standard new conventino to construct them.
type
ProofPtr = ptr Proof
proc new(_: ProofPtr): ProofPtr =
...Same for the verify types.
munna0908
force-pushed
the
feat/async-prover
branch
2 times, most recently
from
0b7c77c to
c486e8c
Compare
munna0908
force-pushed
the
feat/async-prover
branch
from
1de746b to
f907cbc
Compare
This PR adds multi-threading support to the circompat backend to prevent blocking during proof generation and verification.