Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the implementations of Depth_First_Search, Breadth_First_Search, BellmanFord_Algo , Floyyd_Warshall_Algo , KruskalAlgo , MergeSort , Prims_Algo ,TopologicalSort ,DSU_Template among others. #145

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added the implementations of Depth_First_Search, Breadth_First_Search, BellmanFord_Algo , Floyyd_Warshall_Algo , KruskalAlgo , MergeSort , Prims_Algo ,TopologicalSort ,DSU_Template among others. #145

wants to merge 2 commits into from

Conversation

sonicdashh
Copy link

@sonicdashh sonicdashh commented Oct 6, 2023 •
edited
Loading

Added the implementations of Depth_First_Search, Breadth_First_Search, BellmanFord_Algo , Floyyd_Warshall_Algo , KruskalAlgo , Prims_Algo ,TopologicalSort ,DSU_Template among others.

What's being changed:

Checkoff the following:

  • Read Contribution.md
  • Created a new branch before committing.
  • My File doesn't contain any duplicacy or misinformation (isn't available in the library).
  • Added to the right category.
  • Added "add code" label.
  • Described what's being changed.

@sonicdashh
Added the implementations of Depth_First_Search, Breadth_First_Search…
4c9aaf9 
…,BellmanFord_Algo , Floyyd_Warshall_Algo , KruskalAlgo , MergeSort , Prims_Algo ,TopologicalSort ,DSU_Template among others.
@sonicdashh
Copy link
Author

sonicdashh commented Oct 6, 2023 •
edited
Loading

@codewithdev
Please merge PR #145.

@sonicdashh sonicdashh mentioned this pull request Oct 8, 2023
Closed
codewithdev
codewithdev reviewed Oct 8, 2023
View reviewed changes
Graph_Algorithms/Floyyd_Warshall.cpp
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a quick introduction at the top (before line 1).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

codewithdev
codewithdev reviewed Oct 8, 2023
View reviewed changes
Copy link
Owner

@codewithdev codewithdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check out the master branch, and validate all the existing algos before raising a PR. Thanks.

Graph_Algorithms/Kruskal.cpp
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the issue exactly?

@codewithdev
Copy link
Owner

https://github.com/codewithdev/C-plus-plus-Algorithms/blob/master/25-Graph%20Theory/dijkstras.cpp is already present in the base. Can you filter this out in your commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codewithdev codewithdev codewithdev left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sonicdashh @codewithdev