Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Implement zero dependency #4

Merged
merged 19 commits into from
Jul 16, 2024
Merged

refactor: Implement zero dependency #4

merged 19 commits into from
Jul 16, 2024

Conversation

oluwatobiss
Copy link
Member

This PR does the following:

  • Drop all dependencies.
  • Use the intersection observer API to optimize the performance of infinite scrolling.
  • Delete the uniqueName prop (Breaking Change)

oluwatobiss added 19 commits July 14, 2024 19:49
@oluwatobiss
build: Drop react-loader-spinner dependency
8da1c02
@oluwatobiss
style: Change class declaration to function
bf06811
@oluwatobiss
style: Change javascript file to typescript
5a53ff0
@oluwatobiss
build: Drop fslightbox-react dependency
366d15d
@oluwatobiss
build: Drop prop-types dependency
33535e0
@oluwatobiss
fix: Stop video when lightbox is closed
9cdc3de
@oluwatobiss
refactor: Use async/await to implement asynchronous logic
0ef52ee
@oluwatobiss
refactor: Rename youtubeVideoFiguresArray to videoCardsArray
712d5e1
@oluwatobiss
refactor: Separate gallery and loader's container
cc4a06b
@oluwatobiss
refactor: Make infinite scrolling performant
85e097f
@oluwatobiss
refactor: Create video cards only while rendering gallery
9f2271f
@oluwatobiss
test: Mock the intersection observer api
23da8ca
@oluwatobiss
refactor!: Delete uniqueName prop
29df23c
@oluwatobiss
fix: Open lightbox when keyboard enter key is pressed on video card
3112a50
@oluwatobiss
refactor: Delete redundant isNotFetchingData state
ac0a70b
@oluwatobiss
chore: Delete console.log
444f030
@oluwatobiss
build: Bump dev dependencies
370c88d
@oluwatobiss
docs: Delete uniqueName prop
e8570f4
@oluwatobiss
docs: Update description
67799ef
@oluwatobiss oluwatobiss added the enhancement New feature or request label Jul 16, 2024
@oluwatobiss oluwatobiss self-assigned this Jul 16, 2024
@oluwatobiss oluwatobiss merged commit 9ed984a into main Jul 16, 2024
2 checks passed
@oluwatobiss oluwatobiss deleted the refactor/implement-zero-dependency branch July 16, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oluwatobiss oluwatobiss

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@oluwatobiss