execute mkvmerge only once

Author: s-n-g

pyradio/config_window.py

@@ -55,7 +55,7 @@ class PyRadioConfigWindow(object):
     'This is the equivalent to the -u , --use-player command line option.', '|',
     'Example:', '  player = vlc', 'or', '  player = vlc,mpv, mplayer', '|',
     'Default value: mpv,mplayer,vlc'])
-    _help_text.append([r'If this option is enabled, the last local playlist loaded before terminating, will be automatically opened the next time PyRadio is executed. Furthermore, playback will resume, if it was on when PyRadio exited. Otherwise, station selection will be restored.', '|', 'This option will take precedence over the "Def. playlist" configuration option and the "-s" command line option.', '|', 'It can also be toggled on the fly by pressing \l while on Main mode.', '|', 'Default value: False'])
+    _help_text.append([r'If this option is enabled, the last local playlist loaded before terminating, will be automatically opened the next time PyRadio is executed. Furthermore, playback will resume, if it was on when PyRadio exited. Otherwise, station selection will be restored.', '|', 'This option will take precedence over the "Def. playlist" configuration option and the "-s" command line option.', '|', r'It can also be toggled on the fly by pressing \l while on Main mode.', '|', 'Default value: False'])
     _help_text.append(['This is the playlist to open at start up, if none is specified and "Open last playlist" is not set.', '|',
     'This is the equivalent to the -s, --stations command line option.', '|',
     'Default value: stations'])

pyradio/player.py

@@ -3738,6 +3738,7 @@ def __init__(
             encoding='urf-8'
             ):
         # cover_dir is the data dir
+        self._mkvmerge_is_done = False
         self._cnf = config
         self._playlist = os.path.basename(self._cnf.station_path)[:-4]
         self._chapters_time_function = chapter_time
@@ -3828,18 +3829,32 @@ def write_chapters_to_file(self, input_file):
                     logger.info('mkvmerge not found!')
 
     def write_chapters_to_file_thread(self, input_file):
+        if self._mkvmerge_is_done:
+            if logger.isEnabledFor(logging.INFO):
+                logger.info('Already execute mkvmerge; terminating')
+            return
         opts = []
         self._tag_file = input_file[:-4] + '.xml'
         # remove tmp_ from begining of filename
         self._tag_file = self._remove_starting_tmp_string(self._tag_file)
         opts = [self.mkvmerge,
                 '--global-tags', self._tag_file,
                 ]
+        self._output_file = None
+        self._mkv_file = None
         if self.create_chapter_file(input_file):
             if len(self._list) > 1:
                 opts.extend([
                     '--chapters', self._chapters_file,
                     ])
+        if self._output_file is None:
+            if logger.isEnabledFor(logging.INFO):
+                logger.info('Output file is None... Quiting mkvmerge')
+            return
+        elif self._mkv_file is None:
+            if logger.isEnabledFor(logging.INFO):
+                logger.info('MKV file is None... Quiting mkvmerge')
+            return
         t_dir_dir = os.path.dirname(self._tag_file)
         cover_file = None
         for n in (
@@ -3860,9 +3875,6 @@ def write_chapters_to_file_thread(self, input_file):
                 '--attachment-name', 'cover',
                 '--attach-file', cover_file
                 ])
-        logger.error('\n\nopts = {}\n\n'.format(opts))
-        logger.error(f'{self._output_file = }')
-        logger.error(f'{self._mkv_file = }')
         opts.extend([
             '-o', self._output_file,
             self._mkv_file
@@ -3881,6 +3893,7 @@ def write_chapters_to_file_thread(self, input_file):
         if p.returncode == 0:
             if logger.isEnabledFor(logging.INFO):
                 logger.info('MKV merge successful!')
+            self._mkvmerge_is_done = True
             for n in self._chapters_file, self._tag_file, self._mkv_file:
                 try:
                     os.remove(n)