do not allow to change the Recording Directory while recording is on

Author: s-n-g

pyradio/config_window.py

@@ -107,16 +107,21 @@ class PyRadioConfigWindow(object):
 
     load_default_or_saved_parameters = False
 
-    def __init__(self, parent, config,
-                 toggle_transparency_function,
-                 update_transparency_function,
-                 show_theme_selector_function,
-                 save_parameters_function,
-                 reset_parameters_function,
-                 show_port_number_invalid,
-                 parameters_editing_error=None,
-                 global_functions=None
-        ):
+    def __init__(
+            self,
+            parent,
+            recording_function,
+            config,
+            toggle_transparency_function,
+            update_transparency_function,
+            show_theme_selector_function,
+            save_parameters_function,
+            reset_parameters_function,
+            show_port_number_invalid,
+            parameters_editing_error=None,
+            global_functions=None
+            ):
+        self._is_recording = recording_function
         self.parameters_editing_error = parameters_editing_error
         self._local_functions = {
             ord('j'): self._go_down,
@@ -723,7 +728,8 @@ def keypress(self, char):
                  1  cancel saving config
                  2  cancel a dirty config (not active currently)
                  3  open online browser config
-                 4 open recording dir selection window
+                 4  open recording dir selection window
+                 5  show recording is on error message
         '''
         if self.too_small:
             return 1, []
@@ -761,6 +767,8 @@ def keypress(self, char):
             return -1, []
 
         elif val[0] == 'recording_dir':
+            if self._is_recording() > 0:
+                return 5, []
             return self.n_u.INSERT_RECORDINGS_DIR_MODE, []
 
         elif val[0] == 'radiobrowser':

pyradio/messages_system.py

@@ -1109,6 +1109,19 @@ def set_text(self, parent, *args):
 If none of them is installed, close this window and
 press |F8| to get to the player installation window.
 
+'''
+),
+
+    'M_REC_IS_ON_NO_DIR': ('Recording is active',
+r'''
+|PyRadio| is currently recording a station!
+
+Changing the |Recording Directory| while recording a
+station is not allowed.
+
+Please stop the playback of the station (effectively
+stopping the recording) and try again.
+
 '''
 ),
 

pyradio/player.py

@@ -3860,12 +3860,16 @@ def write_chapters_to_file_thread(self, input_file):
                 '--attachment-name', 'cover',
                 '--attach-file', cover_file
                 ])
+        logger.error('\n\nopts = {}\n\n'.format(opts))
+        logger.error(f'{self._output_file = }')
+        logger.error(f'{self._mkv_file = }')
         opts.extend([
             '-o', self._output_file,
             self._mkv_file
             ])
         if logger.isEnabledFor(logging.DEBUG):
             logger.debug('merge options = {}'.format(opts))
+        logger.error('\n\nopts = {}\n\n'.format(opts))
         p = subprocess.Popen(
                 opts, shell=False,
                 stdout=subprocess.PIPE,

pyradio/radio.py

@@ -4306,6 +4306,7 @@ def _show_config_window(self):
         if self._config_win is None:
             self._config_win = PyRadioConfigWindow(
                 self.outerBodyWin,
+                lambda: self.player.recording > 0 and self.player.isPlaying(),
                 self._cnf,
                 self._toggle_transparency,
                 self._update_transparency,
@@ -6837,7 +6838,7 @@ def keypress(self, char):
                 msg = ( 'Error saving config. Press any key to exit...',
                         'Config saved successfully!!!',
                         'Config saved - Restarting playback (parameters changed)')
-                if ret not in (2, 3):
+                if ret not in (2, 3, 5):
                     self.ws.close_window()
                     self.bodyWin.box()
                     self._print_body_header()
@@ -6969,6 +6970,14 @@ def keypress(self, char):
                 # elif ret ==2:
                 #     ''' cancel a dirty config '''
 
+                elif ret == 5:
+                    ''' recording is on
+                        cannot open recording dir selection window
+                    '''
+                    if logger.isEnabledFor(logging.DEBUG):
+                        logger.debug('Cannot open Recording Selector Window; recording is on!')
+                    self._open_simple_message_by_key('M_REC_IS_ON_NO_DIR')
+                    return
                 else:
                     ''' restore transparency, if necessary '''
                     if self._config_win._config_options['use_transparency'][1] != self._config_win._saved_config_options['use_transparency'][1]: