Refactor SSH process monitoring to support VS Code forks #665

EhabY · 2025-12-01T15:34:13Z

Extract SSH process discovery and network status display into a
dedicated SshProcessMonitor class. Add centralized Remote SSH extension
detection to support Cursor, Windsurf, and other VS Code forks.

Key changes:

Extract SSH monitoring logic from remote.ts into sshProcess.ts
Add sshExtension.ts to detect installed Remote SSH extension
Use createRequire instead of private module._load API to load the Remote SSH extension
Fix port detection to find most recent port (handles reconnects)
Add Cursor's "Socks port:" log format to port regex

Closes #660

src/remote/remote.ts

src/util.ts

EhabY · 2025-12-02T14:28:54Z

src/remote/sshProcess.ts

+	// Poll interval for SSH process and file discovery
+	pollInterval?: number;


Should this one be exponential? Right now it will keep retrying every second forever if it cannot find the SSH process :/

If made exponential, do put a ceiling in, like 30s.

src/remote/sshProcess.ts

EhabY · 2025-12-02T14:32:05Z

src/remote/sshProcess.ts

+				const stats = await fs.stat(networkInfoFile);
+				const ageMs = Date.now() - stats.mtime.getTime();
+
+				if (ageMs > staleThreshold) {
+					// Prevent tight loop: if we just searched due to stale, wait before searching again
+					const timeSinceLastSearch = Date.now() - this.lastStaleSearchTime;
+					if (timeSinceLastSearch < staleThreshold) {
+						await this.delay(staleThreshold - timeSinceLastSearch);
+						continue;
+					}


This is the reconnection detection logic, the issue here is that we do not get events for disconnecting or connecting and thus we have no way to subscribe to them. So what I did here, was assume a connection is stale if the network stats file (generated by the CLI) does not change in poll * 5 seconds - If a network is stale and we find the same process then nothing would break so it's harmless, just means we have to search again.

dedicated SshProcessMonitor class. Add centralized Remote SSH extension detection to better support Cursor, Windsurf, and other VS Code forks. Key changes: - Extract SSH monitoring logic from remote.ts into sshProcess.ts - Add sshExtension.ts to detect installed Remote SSH extension - Use createRequire instead of private module._load API - Fix port detection to find most recent port (handles reconnects) - Add Cursor's "Socks port:" log format to port regex

mafredri

No major issues spotted, nice refactor 👍🏻 (albeit a bit much TS for me today 😂)

src/remote/sshExtension.ts

src/util.ts

mafredri · 2025-12-04T13:26:33Z

src/remote/sshProcess.ts

+	 * When found, starts monitoring.
+	 */
+	private async searchForProcess(): Promise<void> {
+		const { pollInterval, logger, sshHost } = this.options;


sshHost only seems to be used for logging, don't we need to filter anything based on it?

We do not no, the port is sufficient (this is based on the old logic that was refactored here). Using the hostname to search was an approach I tested out but it's worse because we can have the same host connected on multiple windows so there's no way to tell them apart...

Should we remove it from the options to simplify or still valuable as a log? Either way, up to you 👍🏻.

src/remote/sshProcess.ts

src/util.ts

mafredri · 2025-12-04T13:34:35Z

src/remote/sshProcess.ts

+		// output_logging folder doesn't exist
+	}
+
+	return undefined;


Minor concern, if our trys always fail, we'll end up in a polling interval, never informing the user of anything (searchForProcess)?

They would get SSH process search attempt ${attempt} for host: ${sshHost}, do you mean that they won't know it failed at that process exactly? 🤔

I suppose it's more like a potential danger that we never stop trying even if it's never going to match (maybe some expectation changes in the future, etc). And the user has to realize that even though it keeps logging that, it will never resolve.

I'll go through the different pollings and try to make sure we have sufficient logging (but not too much). So at least if there's a failure here the users know why it might have happened (in this case, it could be that the Remote - SSH log location was changed or somehow never written)

mafredri · 2025-12-04T13:36:40Z

src/remote/sshProcess.ts

+	// Poll interval for SSH process and file discovery
+	pollInterval?: number;


If made exponential, do put a ceiling in, like 30s.

src/remote/sshProcess.ts

src/remote/remote.ts

jakehwll

I'm happy from a Typescript-side of things 🙂 Once @mafredri's comments are resolved LGTM

mafredri

Looks great, thanks!

mafredri · 2025-12-05T10:39:35Z

src/util.ts

 	const lastMatch = allMatches.at(-1)!;
+	// Each capture group corresponds to a different Remote SSH extension log format:
+	// [0] full match, [1] and [2] ms-vscode-remote.remote-ssh,
+	// [3] windsurf/open-remote-ssh/antigravity, [4] anysphere.remote-ssh


mafredri · 2025-12-05T10:42:01Z

test/unit/util.test.ts

+		`;
+		expect(findPort(log)).toBe(3333);
+	});
+});


This is awesome, thanks for adding it!

EhabY force-pushed the fix-log-file-finding-for-non-ms-vs-code branch 2 times, most recently from 1797956 to 68fa375 Compare December 1, 2025 19:51

EhabY mentioned this pull request Dec 2, 2025

Coder: View Logs can show the wrong log file #284

Open

EhabY changed the title ~~Fix log file finding for non ms vs code~~ Refactor SSH process monitoring to support VS Code forks Dec 2, 2025

EhabY requested review from jakehwll and mafredri December 2, 2025 14:24

EhabY commented Dec 2, 2025

View reviewed changes

EhabY mentioned this pull request Dec 2, 2025

fix: add connection status indicator to vscode windows, windsurf, open-remote-ssh #492

Merged

EhabY added 3 commits December 2, 2025 20:49

Add tests

3cdbbcf

Refactoring

e7f92b2

EhabY force-pushed the fix-log-file-finding-for-non-ms-vs-code branch from e20c456 to e7f92b2 Compare December 2, 2025 17:50

mafredri reviewed Dec 4, 2025

View reviewed changes

Address review comments

cf63417

jakehwll approved these changes Dec 4, 2025

View reviewed changes

EhabY requested a review from mafredri December 5, 2025 09:37

mafredri approved these changes Dec 5, 2025

View reviewed changes

		// Poll interval for SSH process and file discovery
		pollInterval?: number;

Refactor SSH process monitoring to support VS Code forks #665

Are you sure you want to change the base?

Refactor SSH process monitoring to support VS Code forks #665

Uh oh!

Conversation

EhabY commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

EhabY Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mafredri left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

EhabY Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jakehwll left a comment

Choose a reason for hiding this comment

Uh oh!

mafredri left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

EhabY commented Dec 1, 2025 •

edited

Loading

EhabY Dec 2, 2025 •

edited

Loading

EhabY Dec 4, 2025 •

edited

Loading