-
Notifications
You must be signed in to change notification settings - Fork 34
Add SSE fallback to some one way WS connections #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
352c38b to
bd3a0d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked into tests yet, but I can give a few observations now 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I didn't dive too deep. I don't see anything concerning, but it might be feasible to ask @code-asher for another look.
|
Sorry, did not get a chance to review, I can do it next Monday if we want another pass. |
Add SSE fallback to some WS connections:
/api/v2/workspaces/${workspace.id}/watch-ws->/api/v2/workspaceagents/${agentId}/watch-metadata/api/v2/workspaceagents/${agentId}/watch-metadata-ws->/api/v2/workspaceagents/${agentId}/watch-metadataRestored the previous code regarding
createStreamingFetchAdapterto stream in SSE events.OneWayWebSocket.CoderApiCloses #620