fix(jupyterlab): empty-positional-root-dir

[spapa013]

Description

The JupyterLab module's run.sh builds the launch command with a
BASE_URL_FLAG variable that is only set when base_url is non-empty.
With subdomain = true, base_url is empty, so the flag expands to an
empty argument. Jupyter reads that empty argument as a positional (the
directory to open), which overrides ServerApp.root_dir — so a
user-configured root_dir is silently ignored.

This drops BASE_URL_FLAG and passes --ServerApp.base_url=${BASE_URL}
inline. An empty value normalizes to / and is never treated as a
positional, so root_dir is respected in both the subdomain and
path-based cases.

Type of Change

• Bug fix

Module Information

Path: registry/coder/modules/jupyterlab
New version: v1.2.3
Breaking change: No

Testing & Validation

• Changes tested locally (Coder workspace, subdomain routing: launch
  line shows --ServerApp.base_url= with no empty positional, and
  root_dir is honored)

Related Issues

Closes #1026

[matifali]

Suggested change

[matifali]

Suggested change

	$BASE_URL_FLAG \
	--ServerApp.base_url=${BASE_URL} \

may be drop BASE_URL_FLAG altogether and directly pass BASE_URL?

[spapa013]

Good call — done. Dropped BASE_URL_FLAG and now pass
--ServerApp.base_url=${BASE_URL} inline. Verified locally in a subdomain
workspace.